Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): Better handling of captioned messages in federated conversations #12256

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(chat): Better handling of captioned messages in federated conversations #12256

merged 1 commit into from
May 16, 2024

Conversation

nickvergessen
Copy link
Member

🛠️ API Checklist

Local

Bildschirmfoto vom 2024-05-03 11-23-50

Before (avatar missing because I ran tests locally)

Bildschirmfoto vom 2024-05-03 11-39-28

After

Bildschirmfoto vom 2024-05-03 11-23-42

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels May 3, 2024
@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone May 3, 2024
@nickvergessen nickvergessen self-assigned this May 3, 2024
@nickvergessen
Copy link
Member Author

/backport to stable29

Antreesy
Antreesy reviewed May 6, 2024
View reviewed changes
lib/Chat/Parser/SystemMessage.php Show resolved Hide resolved
lib/Chat/Parser/SystemMessage.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-message-when-sharing-a-file branch from f35c638 to df1084f Compare May 8, 2024 10:56
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-message-when-sharing-a-file branch from df1084f to 8c5e5ac Compare May 10, 2024 10:48
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-message-when-sharing-a-file branch from 8c5e5ac to 27c64b6 Compare May 10, 2024 14:50
@nickvergessen nickvergessen force-pushed the bugfix/noid/improve-message-when-sharing-a-file branch from 27c64b6 to dc2682e Compare May 16, 2024 14:58
@nickvergessen nickvergessen enabled auto-merge May 16, 2024 14:58
@nickvergessen nickvergessen merged commit b3787e4 into main May 16, 2024
63 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/improve-message-when-sharing-a-file branch May 16, 2024 16:12
@backportbot backportbot bot mentioned this pull request May 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Antreesy