Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Remove duplicate method isFederatedRemoteRoom() vs isFederatedConversation() #11795

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix(federation): Remove duplicate method isFederatedRemoteRoom() vs isFederatedConversation() #11795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Federation/CloudFederationProviderTalk.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ private function shareUnshared(int $remoteAttendeeId, array $notification): arra
}

// Sanity check to make sure the room is a remote room
if (!$room->isFederatedRemoteRoom()) {
if (!$room->isFederatedConversation()) {
throw new ShareNotFound(FederationManager::OCM_RESOURCE_NOT_FOUND);
}

Expand Down Expand Up @@ -303,7 +303,7 @@ private function roomModified(int $remoteAttendeeId, array $notification): array
}

// Sanity check to make sure the room is a remote room
if (!$room->isFederatedRemoteRoom()) {
if (!$room->isFederatedConversation()) {
throw new ShareNotFound(FederationManager::OCM_RESOURCE_NOT_FOUND);
}

Expand Down Expand Up @@ -341,7 +341,7 @@ private function messagePosted(int $remoteAttendeeId, array $notification): arra
}

// Sanity check to make sure the room is a remote room
if (!$room->isFederatedRemoteRoom()) {
if (!$room->isFederatedConversation()) {
throw new ShareNotFound(FederationManager::OCM_RESOURCE_NOT_FOUND);
}

Expand Down
7 changes: 0 additions & 7 deletions lib/Room.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,13 +415,6 @@ public function getRemoteToken(): string {
return $this->remoteToken;
}

/**
* @deprecated
*/
public function isFederatedRemoteRoom(): bool {
return $this->remoteServer !== '';
}

public function setParticipant(?string $userId, Participant $participant): void {
// FIXME Also used with cloudId, need actorType checking?
$this->currentUser = $userId;
Expand Down
Loading