Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Conversation): optimize error handling #11665

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix(Conversation): optimize error handling #11665

merged 2 commits into from
Feb 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 28, 2024 •
edited
Loading

☑️ Resolves

  • Splitting work on conversations system:
    • Template was optimised
    • Error handling / displaying moved from services to the store

🖌️ UI Checklist

🚧 Tasks

  • align last message from the chat with last message in the left sidebar

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Feb 28, 2024
@Antreesy Antreesy requested a review from DorraJaouad February 28, 2024 07:48
@Antreesy Antreesy self-assigned this Feb 28, 2024
@Antreesy Antreesy changed the title refactor(Conversation): optimize template fix(Conversation): hide subline from active item, optimize error handling Feb 28, 2024
@Antreesy Antreesy force-pushed the fix/noid/conversation-error-handling branch from cb46776 to 4a58663 Compare February 28, 2024 13:29
@nickvergessen
Copy link
Member

hide subline from active item

Not needed at the moment anymore with #11674
My PR does not "save data" for now, so lets keep it.

@Antreesy Antreesy changed the title fix(Conversation): hide subline from active item, optimize error handling fix(Conversation): optimize error handling Feb 28, 2024
DorraJaouad
DorraJaouad approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/services/conversationsService.js Show resolved Hide resolved
src/components/LeftSidebar/ConversationsList/Conversation.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/conversation-error-handling branch from 4a58663 to 8d6e004 Compare February 29, 2024 08:10
@Antreesy Antreesy enabled auto-merge February 29, 2024 08:10
@Antreesy Antreesy merged commit c07fb6f into main Feb 29, 2024
45 checks passed
@Antreesy Antreesy deleted the fix/noid/conversation-error-handling branch February 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad