Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(MessagesList): Soft update messages list AND add sticky date separator. #11592

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Feb 15, 2024

☑️ Resolves

  • Fix Make last date divider sticky #4610

  • Refactor messages groups. It is now broken down by Date then by Author+time .

  • Light refactoring for MessagesList, it was necessary 😶.

  • Soft update messages list, keep the same object and modify only what was changed.

  • Added sticky date separator.

Note

As the date is sticky and the loading spinner needs to be in absolute position, it will be overlapped. Therefore, the loading spinner should be in another position other than middle, change the loading visualisation, or removed ( like in other messengers where the date separator is sticky)

Issues found to fix:

  • Need more accurate calculation in the comparison between viewport and ul top values ( there is a slight positive gap that should be taken into account)
  • The loading spinner ( see above )

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Recording.2024-02-21.190948.mp4

🚧 Tasks

  • Check Soft update thoroughly
  • Reduce the opacity when it is shown sticky and/or make it darker in order to not to blend with system messages?

Follow-up

  • Date separators label are updating when today becomes yesterday ( leave chat open and pass midnight).
  • Spinner position is not perfect

🏁 Checklist

@DorraJaouad DorraJaouad added enhancement feature: chat 💬 Chat and system messages labels Feb 15, 2024
@DorraJaouad DorraJaouad added this to the 💞 Next Major (29) milestone Feb 15, 2024
@DorraJaouad DorraJaouad self-assigned this Feb 15, 2024
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from ddf4614 to e65c1b5 Compare February 16, 2024 12:42
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from 1a687be to 4b99a5d Compare February 19, 2024 11:58
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here goes the first part. Haven't check soft update and sticky update yet

src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from 4bfad7f to 2fcdd04 Compare February 21, 2024 13:44
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from 2fcdd04 to fb4c381 Compare February 21, 2024 17:40
@DorraJaouad DorraJaouad marked this pull request as ready for review February 21, 2024 18:12
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.spec.js Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from b4058a2 to 45da014 Compare February 22, 2024 19:41
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, the finish line

src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@DorraJaouad DorraJaouad changed the title Feat(MessagesList): Add sticky date separator. Feat(MessagesList): Soft update messages list AND add sticky date separator. Feb 23, 2024
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch 3 times, most recently from 9b9eb3a to 343f3e6 Compare February 26, 2024 16:13
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the important code is good, if there's any regressions, we'll find them soon)

Couple of things:

  • all grouping code I'd move to composable, but not neccessary now
  • sticky date could remain longer on the screen
  • currentDay isn't reliable as-is
  • loading spinner is still badly visible. Maybe we could adjust it like this, aligned with avatars:

image

.scroller {
	padding-top: 4px;

	&__loading {
		top: 4px;
		left: // adjust;
		height: 32px;
		width: 32px;
	}
}

src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/components/MessagesList/MessagesList.vue Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch 2 times, most recently from 4f22e26 to 22ae761 Compare February 27, 2024 14:17
@DorraJaouad DorraJaouad force-pushed the feat/4610/sticky-date-separator branch from 22ae761 to 8f599c2 Compare February 28, 2024 16:44
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to face inevitable

@DorraJaouad DorraJaouad merged commit f158f92 into main Feb 28, 2024
45 checks passed
@DorraJaouad DorraJaouad deleted the feat/4610/sticky-date-separator branch February 28, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make last date divider sticky
2 participants