-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(MessagesList): Soft update messages list AND add sticky date separator. #11592
Conversation
ddf4614
to
e65c1b5
Compare
1a687be
to
4b99a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here goes the first part. Haven't check soft update and sticky update yet
4bfad7f
to
2fcdd04
Compare
2fcdd04
to
fb4c381
Compare
b4058a2
to
45da014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, the finish line
9b9eb3a
to
343f3e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the important code is good, if there's any regressions, we'll find them soon)
Couple of things:
- all grouping code I'd move to composable, but not neccessary now
- sticky date could remain longer on the screen
- currentDay isn't reliable as-is
- loading spinner is still badly visible. Maybe we could adjust it like this, aligned with avatars:
.scroller {
padding-top: 4px;
&__loading {
top: 4px;
left: // adjust;
height: 32px;
width: 32px;
}
}
4f22e26
to
22ae761
Compare
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
…ssage softer Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
22ae761
to
8f599c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to face inevitable
☑️ Resolves
Fix Make last date divider sticky #4610
Refactor messages groups. It is now broken down by Date then by Author+time .
Light refactoring for MessagesList, it was necessary 😶.
Soft update messages list, keep the same object and modify only what was changed.
Added sticky date separator.
Note
As the date is sticky and the loading spinner needs to be in absolute position, it will be overlapped. Therefore, the loading spinner should be in another position other than middle, change the loading visualisation, or removed ( like in other messengers where the date separator is sticky)
Issues found to fix:
Need more accurate calculation in the comparison between viewport and ul top values ( there is a slight positive gap that should be taken into account)🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2024-02-21.190948.mp4
🚧 Tasks
Follow-up
🏁 Checklist