Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NewConversationDialog): refactor and split component #11377

Merged
merged 5 commits into from
Jan 25, 2024
Merged

enh(NewConversationDialog): refactor and split component #11377

merged 5 commits into from
Jan 25, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 12, 2024 •
edited
Loading

☑️ Resolves

  • newGroupConversationStore is redundant -> move functionality to component
  • optimize components

🖌️ UI Checklist

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Jan 12, 2024
@Antreesy Antreesy requested a review from DorraJaouad January 12, 2024 15:58
@Antreesy Antreesy self-assigned this Jan 12, 2024
@Antreesy Antreesy force-pushed the feat/noid/refactor-new-conversation-dialog branch from 5fa4a98 to bb57b58 Compare January 13, 2024 15:13
DorraJaouad
DorraJaouad reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready

src/components/NewConversationDialog/NewConversationSetupPage.vue Outdated Show resolved Hide resolved
DorraJaouad
DorraJaouad approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work 🦅.
Tested and nothing is blocking.
Code-wise, great improvement.

@Antreesy Antreesy force-pushed the feat/noid/refactor-new-conversation-dialog branch from 73c4c60 to 0046904 Compare January 25, 2024 10:53
@Antreesy Antreesy enabled auto-merge January 25, 2024 10:55
@Antreesy Antreesy merged commit f1b3921 into main Jan 25, 2024
36 checks passed
@Antreesy Antreesy deleted the feat/noid/refactor-new-conversation-dialog branch January 25, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad