Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(messagesStore): avoid usage of message.token #11370

Merged
merged 2 commits into from
Jan 13, 2024
Merged

fix(messagesStore): avoid usage of message.token #11370

merged 2 commits into from
Jan 13, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 11, 2024 •
edited by DorraJaouad
Loading

☑️ Resolves

  • Fix prior to federation:
    • federated conversation has token: a and remoteToken: b. When we're fetching something from remote server, we're using b, and messages are coming with token: b in the body, which doesn't belong to current instance
    • forcing to use local token for all messages actions / mutations
    • remove all extra payload from request (don't pass the whole message, if only token/id is needed)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🚧 Tasks

  • Manual testing
  • Code review
  • Follow-up: migrate store to Pinia (not this PR)

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Jan 11, 2024
@Antreesy Antreesy requested a review from DorraJaouad January 11, 2024 10:33
@Antreesy Antreesy self-assigned this Jan 11, 2024
@Antreesy Antreesy force-pushed the fix/noid/detach-token-from-message-store branch from 774df9c to f03979d Compare January 11, 2024 12:19
@Antreesy Antreesy marked this pull request as ready for review January 11, 2024 12:19
@Antreesy Antreesy force-pushed the fix/noid/detach-token-from-message-store branch from e26b774 to a96e100 Compare January 11, 2024 15:49
@Antreesy Antreesy requested a review from DorraJaouad January 11, 2024 16:52
DorraJaouad
DorraJaouad approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on messages, file uploads and breakouts rooms.

@Antreesy
fix(messages): rename purgeMessagesStore method
08ed60e 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(messages): use direct token in components and other stores
683521f 
Signed-off-by: Maksim Sukharev <[email protected]>

fixup! fix(messages): use direct token in components and other stores

- pass token when upload files
- provide a token from component
- revert changes as it creates conflicts with federation chatting PR

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/detach-token-from-message-store branch from a96e100 to 683521f Compare January 13, 2024 10:14
@Antreesy Antreesy merged commit a9377a5 into main Jan 13, 2024
36 checks passed
@Antreesy Antreesy deleted the fix/noid/detach-token-from-message-store branch January 13, 2024 10:17
@Antreesy Antreesy mentioned this pull request Jan 18, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
2. developing feature: federation 🌐 feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad