Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(Mixins): Change getParticipants mixin to composable #11334

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Refactor(Mixins): Change getParticipants mixin to composable #11334

merged 4 commits into from
Jan 12, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

  • Migrate to composable
  • Added a small tweak on joined conversation for one-to-one conversation because it is better to get the status instantly.

@DorraJaouad
Eslint fix
42fd876 
Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad added this to the 💞 Following Major (29) milestone Jan 4, 2024
@DorraJaouad DorraJaouad requested review from ShGKme and Antreesy January 4, 2024 08:49
@DorraJaouad DorraJaouad self-assigned this Jan 4, 2024
Antreesy
Antreesy reviewed Jan 4, 2024
View reviewed changes
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/Participants/ParticipantsTab.vue Outdated Show resolved Hide resolved
ShGKme
ShGKme requested changes Jan 4, 2024
View reviewed changes
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the ref/noid/migrate-get-participants-mixin branch from ebb2985 to d55ce12 Compare January 5, 2024 13:34
@DorraJaouad
Copy link
Contributor Author

Squashed fixups and rebased

ShGKme
ShGKme reviewed Jan 5, 2024
View reviewed changes
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
src/composables/useGetParticipants.js Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the ref/noid/migrate-get-participants-mixin branch from 5154841 to a5fed86 Compare January 6, 2024 13:25
Antreesy
Antreesy approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Reactivity and methods are working fine, couldn't notice anything broken

src/composables/useGetParticipants.js Show resolved Hide resolved
@Antreesy Antreesy requested a review from ShGKme January 8, 2024 09:29
@DorraJaouad DorraJaouad force-pushed the ref/noid/migrate-get-participants-mixin branch 2 times, most recently from fa9495c to 4d91a31 Compare January 8, 2024 11:12
@DorraJaouad DorraJaouad force-pushed the ref/noid/migrate-get-participants-mixin branch from 4d91a31 to 2f497e4 Compare January 8, 2024 14:09
@DorraJaouad DorraJaouad merged commit 11f5314 into main Jan 12, 2024
36 checks passed
@DorraJaouad DorraJaouad deleted the ref/noid/migrate-get-participants-mixin branch January 12, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @ShGKme @Antreesy