Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shares): use FilePicker component directly #11297

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix(shares): use FilePicker component directly #11297

merged 1 commit into from
Dec 27, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

picker.setType is deprecated, but it was responsible for buttons labels => Choose everythere

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Hard to reproduce, but sometimes FilePicker dialog appears behind the main dialog (MediaSettings, ConversationSettings)

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 26, 2023
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 26, 2023
@Antreesy Antreesy requested a review from DorraJaouad December 26, 2023 16:40
@Antreesy Antreesy self-assigned this Dec 26, 2023
DorraJaouad
DorraJaouad approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, nothing is blocking.

src/components/SettingsDialog/SettingsDialog.vue Outdated Show resolved Hide resolved
src/components/SettingsDialog/SettingsDialog.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/11236/apply-file-picker branch from 222973b to b8cdd0e Compare December 27, 2023 11:40
@Antreesy Antreesy enabled auto-merge December 27, 2023 11:42
@Antreesy Antreesy merged commit b061ad6 into main Dec 27, 2023
36 checks passed
@Antreesy Antreesy deleted the fix/11236/apply-file-picker branch December 27, 2023 11:43
@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 28, 2023 •
edited
Loading

/backport to stable28

As we backport Fullscreen PR also

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

FilePicker doesn't open at FullScreen
2 participants
@Antreesy @DorraJaouad