-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): expand system messages group if visual unread marker is set on it #11063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It solved the issue :) but one thing ( not sure about its complexity) :
The VisualLastReadMessageId
is updated after navigating to the conversation for the second time but it also takes a short period to update. This makes the group uncollapsed for the second time too because it caught the initial value of the last read message Id.
I think it should not follow the last read message Id but what that id follows in the first place. From first check, seen
in Message
can be a good candidate but I am not sure.
Originally, it should be UPD: yes, it covers |
Signed-off-by: Maksim Sukharev <[email protected]>
f06f6b8
to
0a9c2b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Ready to go 🦅
/backport to stable28 |
/backport to stable27 |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist