-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SetContacts ): Remove unnecessary scroll #11060
Conversation
/backport to stable28 |
I thought it is expected with more then one line
|
max-height is 90+px, so 2 lines should be shown without scroll
I thought we have the same behavior for NcSelect chips as an example, but they have it separately... maybe force a height of NcButton to 22px? |
51789fe
to
e1b2cdb
Compare
src/components/LeftSidebar/NewGroupConversation/SetContacts/SetContacts.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <[email protected]>
e1b2cdb
to
98770a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
/backport to stable27 |
/backport to stable26 |
☑️ Resolves
Close Button has height 44px in
ContactSelectionBubble
whereas selected contacts div goes lower ( 40.8px), causing the extra scroll.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist