Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SetContacts ): Remove unnecessary scroll #11060

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

Close Button has height 44px in ContactSelectionBubble whereas selected contacts div goes lower ( 40.8px), causing the extra scroll.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

@DorraJaouad
Copy link
Contributor Author

/backport to stable28

@Antreesy
Copy link
Contributor

Antreesy commented Dec 1, 2023

Still issue with 2 lines and more:
image

I remember the issue with 44px, yes =) How about we get rid of NcButton, and put a click event on a whole component?

@DorraJaouad
Copy link
Contributor Author

Still issue with 2 lines and more:

I thought it is expected with more then one line

How about we get rid of NcButton, and put a click event on a whole component?
Hmm, wouldn't that be confusing for the user ?

@Antreesy
Copy link
Contributor

Antreesy commented Dec 1, 2023

I thought it is expected with more then one line

max-height is 90+px, so 2 lines should be shown without scroll

Hmm, wouldn't that be confusing for the user ?

I thought we have the same behavior for NcSelect chips as an example, but they have it separately... maybe force a height of NcButton to 22px?

@DorraJaouad DorraJaouad force-pushed the fix/10755/remove-unnecessary-scroll branch from 51789fe to e1b2cdb Compare December 1, 2023 19:40
@DorraJaouad DorraJaouad changed the title fix(SetContacts ): Add min height fix(SetContacts ): Remove unnecessary scroll Dec 1, 2023
@DorraJaouad DorraJaouad force-pushed the fix/10755/remove-unnecessary-scroll branch from e1b2cdb to 98770a3 Compare December 2, 2023 18:34
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy
Copy link
Contributor

Antreesy commented Dec 3, 2023

/backport to stable27

@Antreesy
Copy link
Contributor

Antreesy commented Dec 3, 2023

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContactSelectionBubble causes unnecessary scroll
3 participants