Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ReactionToaster): Change to animated emojis 🎉 #10772

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 25, 2023

☑️ Resolves

It was agreed that we keep the simple emojis in popover.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Recording.2023-10-26.104022.mp4

🚧 Tasks

  • Visual review
  • Code review

🏁 Checklist

@fancycode
Copy link
Member

Nice! Any chance you could use webp images on browsers that support it to reduce the download sizes? For example the Concerned.gif here is 4.4 MBytes while the webp from https://googlefonts.github.io/noto-emoji-animation/ is only 967 KBytes (for the same 512x512 resolution).

@nickvergessen
Copy link
Member

The size is a bit shocking yeah. Maybe there are smaller versions available? We don't need 512px when we only show them in 26px?

That being said, I guess we should make them a bit bigger? cc @jancborchardt

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to reduce gif's size up to 80% by resizing (https://ezgif.com/resize for example)

And we need to think beforehand of fallbacks, how the emojis roster change may impact

src/components/CallView/shared/ReactionToaster.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/10561/animated-emojis branch from 4f819a2 to bb2aa62 Compare October 26, 2023 08:38
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in? The size can be easily changed afterwards?

@DorraJaouad DorraJaouad merged commit 704068f into master Oct 27, 2023
@DorraJaouad DorraJaouad deleted the feat/10561/animated-emojis branch October 27, 2023 07:32
@jancborchardt
Copy link
Member

That being said, I guess we should make them a bit bigger?

@nickvergessen yeah, they are a bit small currently. We could double the size for sure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated reaction emojis
5 participants