-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ReactionToaster): Change to animated emojis 🎉 #10772
Conversation
Nice! Any chance you could use webp images on browsers that support it to reduce the download sizes? For example the |
The size is a bit shocking yeah. Maybe there are smaller versions available? We don't need 512px when we only show them in 26px? That being said, I guess we should make them a bit bigger? cc @jancborchardt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managed to reduce gif's size up to 80% by resizing (https://ezgif.com/resize for example)
And we need to think beforehand of fallbacks, how the emojis roster change may impact
Signed-off-by: DorraJaouad <[email protected]>
4f819a2
to
bb2aa62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get it in? The size can be easily changed afterwards?
@nickvergessen yeah, they are a bit small currently. We could double the size for sure? |
☑️ Resolves
It was agreed that we keep the simple emojis in popover.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Recording.2023-10-26.104022.mp4
🚧 Tasks
🏁 Checklist