Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(federation): Send room modifications via OCM notifications to re… #10729

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 18, 2023

…motes

☑️ Resolves

🛠️ API Checklist

📺 Samples

  • Create a conversation as userA
  • Invite remote userB
  • Invite remote userC
  • Accept invite as userB
  • Rename conversation as userA
  • As userB check the name in the left sidebar
  • As userC check the name in the invite notification

🚧 Tasks

  • Integration test for the name sample
  • Specifically handle invited but not accepted users (caused BFP locally on testing)
  • Specify list of supported props and increase it Document and type PHP events #10731
  • Check list of types for new and old values on the events

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 18, 2023
@nickvergessen nickvergessen self-assigned this Oct 18, 2023
@nickvergessen nickvergessen mentioned this pull request Oct 19, 2023
7 tasks
@nickvergessen nickvergessen force-pushed the feat/noid/federate-room-modifications branch 3 times, most recently from 1c2cc4a to 7475422 Compare October 24, 2023 12:08
@ArtificialOwl
Copy link
Member

code looks good, tested on real setup and ✔️

Small note as I do not think this is related to this PR, but description is empty on remote when inviting a new remote user and require to be updated on main instance so it becomes available on remote instance.

@nickvergessen
Copy link
Member Author

Small note as I do not think this is related to this PR, but description is empty on remote when inviting a new remote user and require to be updated on main instance so it becomes available on remote instance.

Yeah, same for all other values. I guess name is actually the only relevant one, because that is shown on the invites. All others would be read from the remote instance once the UI is adjusted to support it.

@nickvergessen nickvergessen merged commit 64cef3b into master Oct 30, 2023
@nickvergessen nickvergessen deleted the feat/noid/federate-room-modifications branch October 30, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants