Add option to hide the room list for all users. #1052
Conversation
|
Btw, I have similar changes upcoming to remove adding participants to a room from the dropdown above the participant list and to remove the share room links. Do you want to have these in a separate PR or included in this one? |
|
Shouldn't it be enough for those if the user is not a moderator/owner of the all? |
|
For regular participants that is enough, but the registered users are owners of their events/rooms and can invite additional moderator users. |
This makes sense for cases where the rooms are managed by a different app and the users should not see all available rooms. Signed-off-by: Joachim Bauch <[email protected]>
Signed-off-by: Joachim Bauch <[email protected]>
|
Changed to get setting from |
| * @return bool | ||
| */ | ||
| public function hideRoomList() { | ||
| return $this->config->getSystemValue('spreed.hide_roomlist', false); |
There was a problem hiding this comment.
What do you think about naming this talk-webinary-only-mode and doing all with one config?
cc @Ivansss
There was a problem hiding this comment.
Hmm, I would rather keep it separate with different options for room list, participant list, etc.
We could however support an additional property that disables multiple things.
There was a problem hiding this comment.
The thing is, it makes no sense for normal Talk installations.
And I dont want us to have to test 4 different config combinations on each release, that's why I would prefer a "full" or "restricted" thing, not multiple different levels.
|
|
||
| this._sidebarView.addTab('participants', { label: t('spreed', 'Participants'), icon: 'icon-contacts-dark' }, this._participantsView); | ||
| }, | ||
| /** | ||
| * @param {string} token | ||
| */ | ||
| _setRoomActive: function(token) { | ||
| if (OC.getCurrentUser().uid) { | ||
| if (this._rooms) { |
There was a problem hiding this comment.
hmm this makes the code execute for guests?!
There was a problem hiding this comment.
Sort of: _rooms is only created for logged in users at
Line 586 in abded2c
|
For now this is not the way we want to go with the UI, so I will close this and it can be looked into again after the Vue rewrite #1347 |
This makes sense for cases where the rooms are managed by a different app and the users should not see all available rooms.