Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ–ΌοΈ Background image (similar to background blur) in calls #9251

Closed
7 tasks done
nickvergessen opened this issue Apr 4, 2023 · 6 comments
Closed
7 tasks done

Comments

@nickvergessen nickvergessen added this to the πŸ’™ Next Major (27) milestone Apr 4, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in πŸ’¬ Talk team Apr 4, 2023
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to πŸ†• Next Major Changelog in πŸ’¬ Talk team Apr 4, 2023
@nickvergessen
Copy link
Member Author

Draft

  • The device picker aka. interstitial view should also be shown/used when opening device settings while being in a call
  • Next to the "Blur background" an option is added to replace the background with an image and picks the option that was used last time
  • On selecting an image a second view of the IV is opened which then allows to pick the actual image
  • A predefined list (check Custom background image for own video in callsΒ #7637) will be provided
  • Ultimately the user could also upload their own background

Open questions

  • How can a user uploaded image be provided inside the WebRTC code
  • Should there be restrictions (dimensions and types)

@marcoambrosini
Copy link
Member

moving design comments here from #7637

1

1st design pass done, feedback welcome. @jancborchardt @nimishavijay @nickvergessen
Please note that the first 3 buttons in the background editor need to be designed, but they will likely be an icon + label. Will need something more complex for the custom one.

Screenshot 2023-04-05 at 16 41 43

@marcoambrosini
Copy link
Member

2

Ok I think I came up with a much better design for this that's way more tidy and much easier to read/scan

Screenshot 2023-04-10 at 14 47 46

cc again @nimishavijay and @jancborchardt for feedback

@ghost
Copy link

ghost commented Apr 11, 2023

The first of the predefined images to select should be the default background image which can be customized under Design by the admin. If there is no custom image set, then the default Nextcloud image with the clouds should appear.

@jancborchardt
Copy link
Member

jancborchardt commented Apr 19, 2023

@marcoambrosini looks really great! Only tiny feedback:

  • "No effect", "Blur" and "Custom" should be capital first letter
  • From @nimishavijay: Button labels are a bit generic, Choose β†’ Join call
  • The "Back" button is not really needed as we have an X in the top right?
  • Silent call silently went away (the 3 dot menu has that)

@jancborchardt jancborchardt moved this to πŸ—οΈ At engineering in πŸ– Design team Apr 19, 2023
@marcoambrosini
Copy link
Member

marcoambrosini commented Apr 19, 2023

@jancborchardt this has all been addressed and merged already :)

The missing call button and options are because this would be an "in call" dialog

@github-project-automation github-project-automation bot moved this from πŸ†• Next Major Changelog to β˜‘οΈ Done in πŸ’¬ Talk team May 4, 2023
@github-project-automation github-project-automation bot moved this from πŸ—οΈ At engineering to πŸŽ‰ Done in πŸ– Design team May 4, 2023
@nickvergessen nickvergessen moved this from β˜‘οΈ Done to πŸ†• Next Major Changelog in πŸ’¬ Talk team May 4, 2023
@AndyScherzinger AndyScherzinger changed the title Background image (similar to background blur) in calls πŸ–ΌοΈ Background image (similar to background blur) in calls May 17, 2023
@ShGKme ShGKme mentioned this issue Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants