Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom background image for own video in calls #7637

Closed
AndyScherzinger opened this issue Jul 23, 2022 · 9 comments
Closed

Custom background image for own video in calls #7637

AndyScherzinger opened this issue Jul 23, 2022 · 9 comments
Assignees
Labels
1. to develop design enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Milestone

Comments

@AndyScherzinger
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
In Talk it is currently possible to blur the background of the video being sent. However it is not possible at the moment to replace the background with a custom image instead.

Describe the solution you'd like
Note that replacing the background with a custom image is already supported by the code that blurs the background; what is missing is a UI to select the custom image (and of course adjusting the code to use the selected image).

The feature are two ways two support that and both should be present in the end, while there is no strict order

  1. select an image from you Nextcloud account or upload one to you Nextcloud account to then be used (the later being an additional step to the first one
  2. select an image from a predefined, talk-shipped set of background images, best to ask @jancborchardt and @nimishavijay for potential background images, usually it is nature/landscape, office and "funny" background images like space or colored balls.

Describe alternatives you've considered
none that I am aware of except using the blur option

Additional context

@nickvergessen
Copy link
Member

Shipped backgrounds have the advantage we can put them into the img/ folder of the app and use them directly.

Uploaded items mean we need a public accessible endpoint which allows to access the image without any permission checks, etc. This has a lot of potential for security risks.

@AndyScherzinger
Copy link
Member Author

Wouldn't you need to know the exact image name and be a participant in the call/room at least?

@AndyScherzinger
Copy link
Member Author

Again as stated there is no particular order, so starting with a fixed and shipped set as step one is just fine.

@danxuliu
Copy link
Member

Note that the composition of the background image and the video is locally done in the browser of the sender participant. Other participants just receive the final video, they do not need access to the background image. Therefore the endpoint would need to be accessed only by the same participant that uploaded the image.

@nickvergessen nickvergessen added feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls 1. to develop and removed 0. Needs triage labels Aug 2, 2022
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Aug 2, 2022
@jancborchardt
Copy link
Member

For simplicity, the default images could be the ones we already ship with Dashboard (some make more sense, some less though).

Or what kinds of images would be expected there? Stock office and home working backgrounds – maybe we need to do a photoshoot? ;)

@nickvergessen
Copy link
Member

For simplicity, the default images could be the ones we already ship with Dashboard (some make more sense, some less though).

Since dashboard can be disabled we would duplicate them to talk.

Or what kinds of images would be expected there?

I would suggest:

  • Office
  • Home-Office
  • Nature
  • Cinema/Theater
  • something (board) gaming related

@jancborchardt jancborchardt moved this to 📄 To do / ready for engineering in 🖍 Design team Apr 3, 2023
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 🆕 Next Major Changelog in 💬 Talk team Apr 4, 2023
@nickvergessen nickvergessen moved this from 🆕 Next Major Changelog to 📄 To do (~10 entries) in 💬 Talk team Apr 4, 2023
@jancborchardt jancborchardt moved this from 🏗️ At engineering to 📐 Design phase in 🖍 Design team Apr 4, 2023
@marcoambrosini

This comment was marked as duplicate.

@marcoambrosini

This comment was marked as duplicate.

@marcoambrosini
Copy link
Member

moving design comments to #9251 as requested by @nickvergessen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop design enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
None yet
Development

No branches or pull requests

5 participants