-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom background image for own video in calls #7637
Comments
Shipped backgrounds have the advantage we can put them into the img/ folder of the app and use them directly. Uploaded items mean we need a public accessible endpoint which allows to access the image without any permission checks, etc. This has a lot of potential for security risks. |
Wouldn't you need to know the exact image name and be a participant in the call/room at least? |
Again as stated there is no particular order, so starting with a fixed and shipped set as step one is just fine. |
Note that the composition of the background image and the video is locally done in the browser of the sender participant. Other participants just receive the final video, they do not need access to the background image. Therefore the endpoint would need to be accessed only by the same participant that uploaded the image. |
For simplicity, the default images could be the ones we already ship with Dashboard (some make more sense, some less though). Or what kinds of images would be expected there? Stock office and home working backgrounds – maybe we need to do a photoshoot? ;) |
Since dashboard can be disabled we would duplicate them to talk.
I would suggest:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
moving design comments to #9251 as requested by @nickvergessen |
How to use GitHub
Is your feature request related to a problem? Please describe.
In Talk it is currently possible to blur the background of the video being sent. However it is not possible at the moment to replace the background with a custom image instead.
Describe the solution you'd like
Note that replacing the background with a custom image is already supported by the code that blurs the background; what is missing is a UI to select the custom image (and of course adjusting the code to use the selected image).
The feature are two ways two support that and both should be present in the end, while there is no strict order
Describe alternatives you've considered
none that I am aware of except using the blur option
Additional context
The text was updated successfully, but these errors were encountered: