Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create shares list report + send it by email + diff #332

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Create shares list report + send it by email + diff #332

wants to merge 22 commits into from

Conversation

FlorentPoinsaut
Copy link

@FlorentPoinsaut FlorentPoinsaut commented Sep 28, 2022 •
edited
Loading

Hi,

I'm working to add some features (create file report, email it, and diff from month to month).
It's not finished but I'm creating this PR to share my work as I go along and to avoid someone else spending time on the same features.

ToDo:

  • email notification
  • upload files as nextcloud file instead of email attachment
  • diff from month to month
  • README update

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Send shares list by email + add output option for shareslist command ((JSON + CSV) WIP: Send shares list by email + add output option for shareslist command (JSON + CSV) Sep 28, 2022
@FlorentPoinsaut FlorentPoinsaut marked this pull request as draft September 29, 2022 07:20
@CarlSchwan
Copy link
Member

I like these features but would it be possible to split this in multiple PR (make it easier to review)

@CarlSchwan CarlSchwan self-requested a review September 30, 2022 14:36
@CarlSchwan CarlSchwan added the enhancement New feature or request label Sep 30, 2022
@FlorentPoinsaut
Copy link
Author

FlorentPoinsaut commented Oct 11, 2022 •
edited
Loading

OK @CarlSchwan, I keep this PR for my work and I'm creating few PRs with key features as I go.
First one: #336

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Send shares list by email + add output option for shareslist command (JSON + CSV) WIP: Create shares list report + send it by email Oct 12, 2022
@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Create shares list report + send it by email WIP: Create shares list report + send it by email + diff Oct 12, 2022
CarlSchwan and others added 13 commits October 12, 2022 08:06
@CarlSchwan @FlorentPoinsaut
Show share expiration if it exits
e6757e4 
Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Florent Poinsaut <[email protected]>
@CarlSchwan @FlorentPoinsaut
Add filtering
49f42c7 
Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Send shares list by email (JSON + CSV)
6e8a338 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
add output option for shareslist command
82364da 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Update README
534146d 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Fix getAllShares
6f37d4f 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
use new getAllShares method
449ed34 
Signed-off-by: Florent Poinsaut <[email protected]>
@CarlSchwan @FlorentPoinsaut
Show share expiration if it exits
1d2b505 
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan @FlorentPoinsaut
Add filtering
3ba68c1 
Signed-off-by: Carl Schwan <[email protected]>
@FlorentPoinsaut
Write report on Nextcloud instead of send by email
c6fcad8 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Refacto + class var fixes
5cb6deb 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Add CSV output format
f776998 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Fix getAllShares
cc0cf1b 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Add diff report
67f299c 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
add permissions mapping
35c98cb 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut
Add send command in README
f5d84b5 
Signed-off-by: Florent Poinsaut <[email protected]>
@FlorentPoinsaut FlorentPoinsaut marked this pull request as ready for review November 3, 2022 15:27
@FlorentPoinsaut
Copy link
Author

Done! :)

@FlorentPoinsaut
Copy link
Author

Hi @CarlSchwan!
Does this PR work for you or do youo need some modifications?
Thanks in advance

@CarlSchwan
Copy link
Member

Hi, sorry I was in vacation the last two weeks and I just came back. i'll try to check it out today

@FlorentPoinsaut
Copy link
Author

Oh great. No rush. I hope you had a great vacation.

@CarlSchwan
Copy link
Member

Please fix eslint and plasm and then I can merge it

@FlorentPoinsaut
Copy link
Author

Hello @CarlSchwan,
I am sorry but :

  • eslint is out of my scope and It's risky for me to modify VueJS code
  • palsm can't find Nextcloud Core class OC\Core\Command\Base, I understand why but I don't kwon how to fix this. Do you have an idea?

@FlorentPoinsaut FlorentPoinsaut changed the title WIP: Create shares list report + send it by email + diff Create shares list report + send it by email + diff Jan 9, 2024
@FlorentPoinsaut
Copy link
Author

Hello @CarlSchwan,

Please could you take a some time to check this PR again?

Thank you in advance.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees

@FlorentPoinsaut FlorentPoinsaut

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentPoinsaut @CarlSchwan