remove reminders from read-only shared calendars #6903
Conversation
Signed-off-by: Georg Ehrke <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6903 +/- ##
============================================
+ Coverage 52.84% 52.84% +<.01%
- Complexity 22816 22817 +1
============================================
Files 1441 1441
Lines 88555 88563 +8
Branches 1349 1349
============================================
+ Hits 46798 46805 +7
- Misses 41757 41758 +1
|
There was a problem hiding this comment.
As a temporary fix for #679 this looks good, but what you said
calendarobjects_per_user table to store custom custom alarms and transparency settings on a per sharee basis
should be implemented instead, as I'm finding useful to have reminders from calendars shared with me as read-only.
While I agree in general, I'd say lets fix the 99% usecase first ;) |
|
Great :-) |
nickvergessen
deleted the
feature/679/remove_valarms_from_read_only_shared_calendars
branch
|
Why is this commit not contained in 12.0.4? |
|
Because we didn't backport it. |
|
I'm on 13b3 now but I still get alarms for calendars I have no write access to. Am I missing something? |
|
@nursoda Can you please open a bug report with detailed reproduction steps? |
|
(If you are using a sync client (and not web interface), it's possible that the alarms are still cached in the calendar data on your client side. Can you try removing the account in your sync client and add it again please) |
|
You are right: After I deleted my DAVdroid account, re-added it and re-synced, old calendar entries with alarms in other user's calendars that are shared to me read-only no longer have an alert for me. Sorry I did not realize myself that caching may be the cause. And thanks for your swift answer! Sidenote: I'm using DAVdroid and BusinessCalendar2. It's a PITA to delete and re-add an account since all BC settings (grouping, colors, reminder tones etc. must be re-set manually). Isn't there an easier way to flush its cache in DAVdroid? Not a nextcloud issue, though. |
|
I just updated to 13, but Birthday Contacts still have reminders (directly in the webinterface, and on all my clients) |
|
@CNeutron Yes, birthday contacts is your calendar, not a shared one. |
|
Well I thought as it is a read only calendar, the reminders would stop waking me up at night. Also kinda because nursoda comments pointed in that direction |
|
As @georgehrke wrote, in bug #1505 wich deals with that enhancement, it's not implemented yet. THIS bug is solved for me (99%, see @nickvergessen's 1st comment above). Thus, should it remain open? |
|
Clearification: |
No, we can't close it, because this is not an issue but a pull-request.
So if you want to take changes from a pull-request into Nextcloud, you merge them, if you don't want to take the changes, you simply close the pull-request. The corresponding issue requesting this feature was automatically closed when merging this pull-request: #679 If you want to learn more details about pull-requests I recommend https://help.github.com/articles/about-pull-requests/ :) |
|
Thank you for your very easy yet comprehensive answer. |
fixes #679