fix(settings): Fix setup check when mail_smptmode is set to "null" #50281
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
solracsf
approved these changes
Jan 20, 2025
|
Does this need to be backported, since the PR intrducing this feature wasn't ? |
Merged
No, you’re right, I misread the user feedback, I though the problem was on 30 but it’s on 31 RC. |
come-nc
requested review from
a team,
artonge,
nfebe and
yemkareems
and removed request for
a team
artonge
approved these changes
Jan 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #48977
Summary
Skip irrelevant setup check when mail_smtpmode is set to "null".
Checklist