Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(login): add origin check at login #49560

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat(login): add origin check at login #49560

merged 2 commits into from
Dec 20, 2024

Conversation

Altahrim
Copy link
Collaborator

Summary

Check Origin header on login page

Checklist

@Altahrim Altahrim added 2. developing Work in progress php Pull requests that update Php code labels Nov 29, 2024
@Altahrim Altahrim added this to the Nextcloud 31 milestone Nov 29, 2024
@Altahrim Altahrim self-assigned this Nov 29, 2024
@Altahrim Altahrim force-pushed the fix/login-origin branch 4 times, most recently from d695288 to dfaf28e Compare December 4, 2024 12:59
artonge added a commit to nextcloud-libraries/nextcloud-cypress that referenced this pull request Dec 4, 2024
This is need as the server is now checking that header too: nextcloud/server#49560

Signed-off-by: Louis Chemineau <[email protected]>
artonge added a commit to nextcloud-libraries/nextcloud-cypress that referenced this pull request Dec 4, 2024
This is need as the server is now checking that header too: nextcloud/server#49560

Signed-off-by: Louis Chemineau <[email protected]>
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2024
@Altahrim Altahrim marked this pull request as ready for review December 5, 2024 09:10
@Altahrim Altahrim requested review from a team, ArtificialOwl, yemkareems and provokateurin and removed request for a team December 5, 2024 09:10
.htaccess Show resolved Hide resolved
@Altahrim Altahrim added the pending documentation This pull request needs an associated documentation update label Dec 11, 2024
@sorbaugh sorbaugh merged commit d4715c6 into master Dec 20, 2024
192 checks passed
@sorbaugh sorbaugh deleted the fix/login-origin branch December 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants