-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable30] Bug/48678/restore dav error response #49481
base: stable30
Are you sure you want to change the base?
Conversation
daac84a
to
4a5de6b
Compare
Conflicts: Constructor property promotion and Imports in Server and ServerFactory |
} | ||
|
||
if ($this->debugExceptions) { | ||
$previous = $e; |
Check notice
Code scanning / Psalm
MissingClosureReturnType Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ why would Psalm complain here but not on master? Bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The psalm run https://github.com/nextcloud/server/actions/runs/12030997029/job/33539600726?pr=49481 does not report it. The reason for this warning could be that #48476 was only done for master, but not backported. However https://github.com/nextcloud/server/actions/runs/12030997029/job/33539601398?pr=49481 does not mention that warning as well. I'm a bit clueless where it comes from ;)
} | ||
|
||
if ($this->debugExceptions) { | ||
$previous = $e; |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
0d60beb
to
20aada5
Compare
|
20aada5
to
c6395b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking
…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>
c6395b9
to
a792ed7
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
a792ed7
to
51b6b9a
Compare
Backport of #49004
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.