Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(core): Do not use v-html for translation output #49363

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 19, 2024

Backport of #49346

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

The content that can be renderered does *not* include HTML (see
`recommended` object).
But `v-html` was used, this is potentially dangerous, even though we
sanitize the translation values, so no urgent harm but better safe than
sorry.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv
Copy link
Member

/compile amend

@skjnldsv skjnldsv marked this pull request as ready for review November 19, 2024 09:51
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv requested review from a team and sorbaugh and removed request for a team November 19, 2024 10:16
@skjnldsv skjnldsv enabled auto-merge November 19, 2024 11:00
@skjnldsv skjnldsv merged commit 75e6e7c into stable30 Nov 19, 2024
113 checks passed
@skjnldsv skjnldsv deleted the backport/49346/stable30 branch November 19, 2024 12:19
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants