Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(files): Allow downloading multiple nodes not from same base #49344

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 18, 2024

Backport of #49203

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from nfebe, skjnldsv and susnux November 18, 2024 12:15
@backportbot backportbot bot added this to the Nextcloud 30.0.3 milestone Nov 18, 2024
@susnux susnux changed the title [stable30] [stable28] fix(files): Allow downloading multiple nodes not from same base [stable30] fix(files): Allow downloading multiple nodes not from same base Nov 18, 2024
@susnux susnux force-pushed the backport/49203/stable30 branch from bc54305 to 081a725 Compare November 18, 2024 12:40
@susnux susnux marked this pull request as ready for review November 18, 2024 12:40
@susnux susnux force-pushed the backport/49203/stable30 branch from 081a725 to 045b318 Compare November 19, 2024 19:23
@susnux
Copy link
Contributor

susnux commented Nov 19, 2024

/compile

@susnux susnux enabled auto-merge November 19, 2024 19:24
@skjnldsv skjnldsv force-pushed the backport/49203/stable30 branch from 8a55c93 to c513595 Compare November 20, 2024 07:27
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2024
@skjnldsv
Copy link
Member

/compile rebase-amend /

susnux and others added 2 commits November 20, 2024 09:06
When downloading files in e.g. the *favorites* or *recent* view,
then the nodes are not always share the same parent folder
and we can not use the current directory as it is probably just a
virtual one.

So we calculate the longest common base and use that as the directory
for the download endpoint.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit 14f3dbe into stable30 Nov 20, 2024
128 checks passed
@susnux susnux deleted the backport/49203/stable30 branch November 20, 2024 09:26
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants