Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] feat: Add X-NC-Disable-Scheduling property to allow skipping scheduling #49234

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 12, 2024

Backport of PR #49139

@backportbot backportbot bot requested a review from miaulalala as a code owner November 12, 2024 15:43
@backportbot backportbot bot requested a review from miaulalala November 12, 2024 15:43
@backportbot backportbot bot requested a review from st3iny as a code owner November 12, 2024 15:43
@backportbot backportbot bot requested a review from st3iny November 12, 2024 15:43
@backportbot backportbot bot added 3. to review Waiting for reviews feature: dav labels Nov 12, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.3 milestone Nov 12, 2024

// do not send imip messages if external system already did
/** @psalm-suppress UndefinedPropertyFetch */
if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === 'true') {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Sabre\VObject\Component\VCalendar does not contain null

// do not send imip messages if external system already did
/** @psalm-suppress UndefinedPropertyFetch */
if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === 'true') {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type Sabre\VObject\Component\VCalendar for $__tmp_nullsafe__3570 is never null
@SebastianKrupinski SebastianKrupinski merged commit 339f6ff into stable30 Nov 13, 2024
171 checks passed
@SebastianKrupinski SebastianKrupinski deleted the backport/49139/stable30 branch November 13, 2024 08:11
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants