Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): open sidebar on sharing tab by default for files #49147

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 8, 2024

Fix #41567
Will fallback to first tab is app is disabled

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files regression feature: file sidebar Related to the file sidebar component labels Nov 8, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 8, 2024
@skjnldsv skjnldsv self-assigned this Nov 8, 2024
@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix/sharing-sidebar-tab-default branch from ba7c434 to 661224b Compare November 8, 2024 10:12
@skjnldsv skjnldsv requested a review from nfebe November 8, 2024 10:13
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the code that opened the activity tab all the time in the past though? 🤔

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

Where is the code that opened the activity tab all the time in the past though? 🤔

nowhere, the activity is just the first tab

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

/compile rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2024
@skjnldsv skjnldsv enabled auto-merge November 8, 2024 13:38
@susnux
Copy link
Contributor

susnux commented Nov 8, 2024

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Nov 8, 2024

/backport to stable29

@nextcloud-command nextcloud-command force-pushed the fix/sharing-sidebar-tab-default branch from 661224b to fe0258c Compare November 8, 2024 13:56
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

Alright, a slight change.
Seems like sharing was expected for both folder and files (legacy)

I'll raise that question on the linked ticket for the design team.
in the meantime, this fixes a few things, so let's get this in

@skjnldsv skjnldsv force-pushed the fix/sharing-sidebar-tab-default branch 3 times, most recently from ed2a5d6 to 5c40c51 Compare November 8, 2024 15:28
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv force-pushed the fix/sharing-sidebar-tab-default branch from 5c40c51 to d432fea Compare November 8, 2024 15:44
@skjnldsv skjnldsv merged commit c870608 into master Nov 8, 2024
118 checks passed
@skjnldsv skjnldsv deleted the fix/sharing-sidebar-tab-default branch November 8, 2024 16:00
Copy link

backportbot bot commented Nov 8, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/49147/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 191e839a f29697a7 d432fea3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49147/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: file sidebar Related to the file sidebar component feature: files regression
Projects
None yet
3 participants