Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SharingEntryLink): Show default password before create if any #49115

Merged

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 6, 2024

Prevent silent addition of expiration date to shares.

Resolves : #48860

Screenshots

No default expiration set Expiration enforced Default expiration set BUT not enforced
Screenshot from 2024-11-07 06-25-03 Screenshot from 2024-11-07 06-19-48 Screenshot from 2024-11-07 06-18-49

@nfebe nfebe force-pushed the fix/48860/stop-silent-expiry-date-addition-on-link-shares branch 3 times, most recently from 28c9676 to 808f07a Compare November 7, 2024 05:27
@nfebe nfebe marked this pull request as ready for review November 7, 2024 05:32
@joshtrichards
Copy link
Member

Looks good!

Related: #46837 (not sure if this fixes that too)

Prevent silent addition of expiration date to shares.

Prevent silent addition for password to shares.

Both now have a `shareRequiresReview` check

Resolves : #48860

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe force-pushed the fix/48860/stop-silent-expiry-date-addition-on-link-shares branch from 808f07a to 6d3f5d3 Compare November 8, 2024 09:07
@nfebe nfebe enabled auto-merge November 8, 2024 09:07
@nfebe
Copy link
Contributor Author

nfebe commented Nov 8, 2024

Related: #46837 (not sure if this fixes that too)

Not exactly might require a separate PR. Took it.

@nfebe
Copy link
Contributor Author

nfebe commented Nov 8, 2024

/compile

@nfebe
Copy link
Contributor Author

nfebe commented Nov 8, 2024

/backport to stable30

@nfebe
Copy link
Contributor Author

nfebe commented Nov 8, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented Nov 8, 2024

/backport to stable28

Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit 2ec74f9 into master Nov 8, 2024
118 checks passed
@nfebe nfebe deleted the fix/48860/stop-silent-expiry-date-addition-on-link-shares branch November 8, 2024 10:21
Copy link

backportbot bot commented Nov 8, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/49115/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d3f5d39 1f17b2f8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49115/stable29

Error: Failed to push branch backport/49115/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

VM1567 core-common.js:150691 [Vue warn]: Error in mounted hook: "TypeError: Cannot set properties of null (setting 'expireDate')"

found in

---> <SharingEntryLink> at apps/files_sharing/src/components/SharingEntryLink.vue
       <SharingLinkList> at apps/files_sharing/src/views/SharingLinkList.vue
         <SharingTab> at apps/files_sharing/src/views/SharingTab.vue
           <NcAppSidebarTab>
             <SidebarTab> at apps/files/src/components/SidebarTab.vue
               <NcAppSidebarTabs>
                 <NcAppSidebar>
                   <Root>

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

@DanScharon
Copy link

the backport to stable29 has not made the cut, correct? Can you retry backporting please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
6 participants