-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SharingEntryLink): Show default password before create if any #49115
fix(SharingEntryLink): Show default password before create if any #49115
Conversation
28c9676
to
808f07a
Compare
Looks good! Related: #46837 (not sure if this fixes that too) |
Prevent silent addition of expiration date to shares. Prevent silent addition for password to shares. Both now have a `shareRequiresReview` check Resolves : #48860 Signed-off-by: fenn-cs <[email protected]>
808f07a
to
6d3f5d3
Compare
Not exactly might require a separate PR. Took it. |
/compile |
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
Signed-off-by: nextcloud-command <[email protected]>
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/49115/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d3f5d39 1f17b2f8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49115/stable29 Error: Failed to push branch backport/49115/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
the backport to stable29 has not made the cut, correct? Can you retry backporting please? |
Prevent silent addition of expiration date to shares.
Resolves : #48860
Screenshots