Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: do not query CNAME if A succeeded already #48675

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

georglauterbach
Copy link
Contributor

@georglauterbach georglauterbach commented Oct 13, 2024

Fixes: #48048

Summary

When an A query succeeds, querying for CNAME again is

  1. useless at best, and
  2. creating unnecessary log entries in the DNS server.

Checklist

@solracsf

This comment was marked as resolved.

@georglauterbach
Copy link
Contributor Author

Tests are failing:

I hope that is fixed with e3d7d84; I am not a PHP programmer, though; hence, I am not sure whether assertNotContains is used correctly here.

@solracsf
Copy link
Member

Another failure:

There was 1 failure:

1) lib\Http\Client\DnsPinMiddlewareTest::testIgnoreSubdomainForSoaQuery
Failed asserting that an array does not contain 'subsubdomain.subdomain.example.com134217728'.

@solracsf solracsf added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 17, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@georglauterbach
Copy link
Contributor Author

I'll be tackling this in two or three days.

@georglauterbach
Copy link
Contributor Author

I updated the tests

@georglauterbach
Copy link
Contributor Author

Checks are waiting for approval

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 6, 2024
@ChristophWurst ChristophWurst requested review from a team, artonge and come-nc and removed request for ChristophWurst and a team November 6, 2024 08:09
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks got besides the typo in the comment :)

tests/lib/Http/Client/DnsPinMiddlewareTest.php Outdated Show resolved Hide resolved
@kesselb kesselb removed their request for review November 6, 2024 10:33
Signed-off-by: georglauterbach <[email protected]>
@come-nc come-nc merged commit 0718984 into nextcloud:master Nov 14, 2024
357 of 360 checks passed
Copy link

welcome bot commented Nov 14, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@come-nc
Copy link
Contributor

come-nc commented Nov 14, 2024

@georglauterbach Thanks a lot! This problem has been bothering people for a long time, I hope this will help reduce the chatter in the logs.

@come-nc
Copy link
Contributor

come-nc commented Nov 14, 2024

/backport to stable30

@come-nc
Copy link
Contributor

come-nc commented Nov 14, 2024

/backport to stable29

@come-nc
Copy link
Contributor

come-nc commented Nov 14, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DNS CNAME record is always queried, even when the query for an A record already succeeded
5 participants