-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS: do not query CNAME if A succeeded already #48675
Conversation
fe0e0d5
to
f3055c2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
I hope that is fixed with e3d7d84; I am not a PHP programmer, though; hence, I am not sure whether |
Another failure:
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
I'll be tackling this in two or three days. |
7aa9055
to
cf99228
Compare
I updated the tests |
Checks are waiting for approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks got besides the typo in the comment :)
Signed-off-by: georglauterbach <[email protected]>
cf99228
to
387cd8b
Compare
Signed-off-by: georglauterbach <[email protected]>
d60c7d9
to
4d517a3
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
@georglauterbach Thanks a lot! This problem has been bothering people for a long time, I hope this will help reduce the chatter in the logs. |
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
Fixes: #48048
Summary
When an A query succeeds, querying for CNAME again is
Checklist