-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly calculate intermediate icon for touch icon generation #47670
Conversation
Signed-off-by: Julius Härtl <[email protected]>
3a300bd
to
463c21d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code makes sense
/backport to stable30 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47670/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 463c21d2
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47670/stable30 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..7964058
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable30 |
Fix touch icon rendering that is used by iOS devices if you add a webpage to the home screen. While the previous logic used to work it seems these days imagick does not have a resolution set for svg files, so we need to change calculation slightly so that our intermediate image has the right sizing for the final icon.
(The resolution naming seems confusing here, it is rather the density https://www.php.net/manual/en/imagick.setimageresolution.php#96182)