Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Ensure share properties are also set on public remote endpoint #46987

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 2, 2024

Summary

Ensure that public and internal endpoint both provide the necessary data, so we can e.g. on both request nc:note.
As the share note is not something only for users but also for public shares.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Aug 2, 2024
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on the very edge between a fix and a feat... 😅🙈
Approved nonetheless!

@Altahrim Altahrim mentioned this pull request Aug 5, 2024
apps/dav/lib/Connector/Sabre/Node.php Outdated Show resolved Hide resolved
apps/dav/lib/Connector/Sabre/Node.php Outdated Show resolved Hide resolved
apps/files_sharing/lib/SharedStorage.php Dismissed Show dismissed Hide dismissed
apps/files_sharing/lib/SharedStorage.php Dismissed Show resolved Hide resolved
apps/dav/lib/Connector/Sabre/FilesPlugin.php Dismissed Show dismissed Hide dismissed
apps/dav/lib/Storage/PublicShareWrapper.php Dismissed Show dismissed Hide dismissed
@susnux susnux merged commit b34edf2 into master Aug 12, 2024
169 checks passed
@susnux susnux deleted the fix/dav-public branch August 12, 2024 10:06
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants