Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files_sharing): show file requests in navigation #46770

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat(files_sharing): show file requests in navigation #46770

merged 3 commits into from
Jul 30, 2024

Conversation

skjnldsv
Copy link
Member

image

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 26, 2024
@skjnldsv skjnldsv requested review from susnux, nfebe, sorbaugh and a team July 26, 2024 07:58
@skjnldsv skjnldsv self-assigned this Jul 26, 2024
@skjnldsv skjnldsv force-pushed the feat/navigation-files-request branch from 32c7078 to 7ba19f6 Compare July 26, 2024 08:08
susnux

This comment was marked as duplicate.

Sign in to view

susnux
susnux approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@skjnldsv skjnldsv requested review from a team and Pytal and removed request for a team July 26, 2024 12:12
nfebe
nfebe approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv
Copy link
Member Author

/compile rebase-amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2024
@nextcloud-command nextcloud-command force-pushed the feat/navigation-files-request branch from 7ba19f6 to 6427ae1 Compare July 30, 2024 09:52
@skjnldsv skjnldsv enabled auto-merge July 30, 2024 10:07
@skjnldsv skjnldsv merged commit b9f35a7 into master Jul 30, 2024
111 checks passed
@skjnldsv skjnldsv deleted the feat/navigation-files-request branch July 30, 2024 10:08
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@susnux susnux susnux approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug enhancement feature: files feature: sharing
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @AndyScherzinger @susnux @nfebe