Update getTestUrls add missing url schemes

[Sprinterfreak]

Prepend url scheme to trusted_domains entries ensures valid domains

Relates #45087
Resolves #45724

Signed-off-by: Jan-Jonas Sämann [email protected]

[joshtrichards]

The later call to getAbsoluteURL() already handles adding the scheme. If it's not, something else is going on here I think...

What is $testUrls getting populated with in your environment (prior to your change)?

[kesselb]

The later call to getAbsoluteURL() already handles adding the scheme.

Not for the trusted_domains, only the url.

I hope that most installations are using https://, but we should not hardcode it and rather use the value from the request object if available.

This needs a bit more rework especially to also make it work for the cli runs or skip the trusted_domains for cli runs because we cannot figure out, unless overwriteprocotol is given, what protocol to use and therefore should only use the cli.overwrite.url.

[Sprinterfreak]

Since the test handles multiple domains and can in theory run from cli, there is not always a request context from which we can infer the 'used' scheme. Also, the result should be somewhat consistent regardless from where it is triggered.
It is of course a good idea to use overwriteprotocol's value if given.

I've found the getTestUrls function to be the most convinient place to fixup values. If there is any better place, just see this as a proof of concept.
I had previously added some substr checks just before the request itself and found it to be not the right solution but it leaves getTestUrls returning invalid values.

Any thaughts?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[Sprinterfreak]

Fixed by other commit 48c807e