-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): ACLs for shared addressbooks #44376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
Waiting for reviews
feature: dav
feature: carddav
Related to CardDAV internals
labels
Mar 21, 2024
ChristophWurst
requested review from
nickvergessen,
st3iny,
tcitworld,
miaulalala and
hamza221
March 21, 2024 09:50
/backport! to stable28 |
/backport! to stable27 |
2 tasks
2 tasks
Failing tests are related:
|
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/dav/acls-shared-addressbook
branch
from
March 21, 2024 10:50
476fd81
to
b6e1685
Compare
miaulalala
approved these changes
Mar 21, 2024
Merged
hamza221
approved these changes
Mar 21, 2024
ChristophWurst
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Mar 21, 2024
Cypress failure doesn't look related, rerunning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: carddav
Related to CardDAV internals
feature: dav
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grant write-properties permission to shared addressbooks (to disable, change the local name, etc)
Checklist