Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update @nextcloud/vue #41472

Merged
merged 1 commit into from
Nov 14, 2023
Merged

chore: Update @nextcloud/vue #41472

merged 1 commit into from
Nov 14, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 14, 2023 •
edited by AndyScherzinger
Loading

Checklist

@susnux
chore: Update @nextcloud/vue
d45ff35 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added 3. to review Waiting for reviews dependencies labels Nov 14, 2023
@susnux susnux added this to the Nextcloud 28 milestone Nov 14, 2023
ChristophWurst
ChristophWurst approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

image

^ found some unexpected white space left of the favorite icon in the sidebar but the same issue exists on master.

dist/core-common.js.LICENSE.txt
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

/**!
* @fileOverview Kickass library to create and place poppers near their reference elements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 14, 2023
@AndyScherzinger AndyScherzinger mentioned this pull request Nov 14, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Nov 14, 2023 •
edited
Loading

theming/admin-settings.cy.ts is still expected to fail, right? Cypress.

@susnux
Copy link
Contributor Author

susnux commented Nov 14, 2023

theming/admin-settings.cy.ts is still expected to fail, right? Cypress.

Yes the fixing PR is still not merged

@blizzz
Copy link
Member

blizzz commented Nov 14, 2023

Then i merge, only two summarizing jobs pending.

@blizzz blizzz merged commit 5c04112 into master Nov 14, 2023
@blizzz blizzz deleted the fix/update-vue-components branch November 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
6 participants
@susnux @blizzz @AndyScherzinger @ChristophWurst @JuliaKirschenheuter @Pytal