Skip to content

fix semaphore unguarding #41263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 2 commits into from
Nov 3, 2023
Merged

fix semaphore unguarding #41263

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531f5d1
fix semaphore guarding
szaimen Nov 3, 2023
b681cf7
address review
szaimen Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Preview/Generator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ public static function guardWithSemaphore(int $semId, int $concurrency) {
* @return bool
*/
public static function unguardWithSemaphore($semId): bool {
if (!is_resource($semId) || !extension_loaded('sysvsem')) {
if ($semId === false || get_class($semId) !== 'SysvSemaphore' || !extension_loaded('sysvsem')) {
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
szaimen marked this conversation as resolved.
Outdated
return false;
}
return sem_release($semId);
Expand Down