"Share with" wording fix in new share panel #41155
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -292,7 +292,7 @@ export default { | |
|
|
||
| computed: { | ||
| title() { | ||
| let title = t('files_sharing', 'Shared with') + ' '; | ||
|
There was a problem hiding this comment. Fine with taking out the space. As for the word There was a problem hiding this comment. You are right but in this case, I won't have the required skills to do such changes ; my skills scope is CSS design and wordings calls change. There was a problem hiding this comment. @fenn-cs could you adjust it so it works in both cases? :) |
||
| if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) { | ||
| title = title + this.share.shareWithDisplayName | ||
| } else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK) { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not make more sense to have full separate strings for every option?
I can imagine there are lanuages that do not work lik "share with" + " " + "option".
E.g. Japanese does not work like that, so it will be pretty hard to translate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. Let's wait for other reviewers' opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @rakekniven
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susnux See my comment below. A screenshot would help a lot.