chore(ocp)!: Drop \OCP\Util::writeLog #38548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
3. to review
ChristophWurst
requested review from
susnux,
blizzz,
solracsf,
CarlSchwan and
JohannesGGE
CarlSchwan
approved these changes
May 31, 2023
solracsf
approved these changes
May 31, 2023
ChristophWurst
added
4. to release
ChristophWurst
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
721f9ee to
33f8c86
Compare
|
Fixed unused imports. Should be fine now. |
kesselb
reviewed
May 31, 2023
| @@ -529,7 +530,7 @@ public function tagAs($objid, $tag) { | |||
| if (is_string($tag) && !is_numeric($tag)) { | |||
| $tag = trim($tag); | |||
| if ($tag === '') { | |||
| \OCP\Util::writeLog('core', __METHOD__.', Cannot add an empty tag', ILogger::DEBUG); | |||
| logger('core')->debug(__METHOD__.', Cannot add an empty tag'); | |||
There was a problem hiding this comment.
$this->logger is also available ;)
rullzer
approved these changes
Jun 1, 2023
ChristophWurst
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
33f8c86 to
b915825
Compare
szaimen
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
b915825 to
d995f11
Compare
ChristophWurst
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
d995f11 to
46cfd66
Compare
ChristophWurst
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
46cfd66 to
0dd616f
Compare
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
chore/ocp/drop-until-writelog
branch
from
64318fe to
e2faf6d
Compare
Merged
skjnldsv
added
2. developing
|
Superseded by #40565 |
ChristophWurst
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The method was deprecated in Nextcloud 13, released 2018-02-06.
TODO
logger(...)https://docs.nextcloud.com/server/27/developer_manual/basics/logging.html#loggingChecklist