Rename numericStorageId to numericExternalStorageId in PersonalMount.php
#38115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt.php so that it doesn't override `numericStorageId` in the `MountPoint` baseclass fixes nextcloud#37473 fixes nextcloud#37414 Signed-off-by: Daniel <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -51,7 +51,7 @@ | |||
| public function __construct( | |||
| UserStoragesService $storagesService, | |||
| StorageConfig $storageConfig, | |||
| $storageId, | |||
| $externalStorageId, | |||
Check notice
Code scanning / Psalm
MissingParamType
szaimen
requested review from
icewind1991,
a team,
ArtificialOwl and
nfebe
and removed request for
a team
|
This PR fixes the issue for me. I do believe this should be backported to v26. |
|
/backport to stable26 Edit: nice! seems like I can just trigger the bot! (I've got no idea what the proper organisational processes are here in this repo) |
|
ArtificialOwl
approved these changes
May 16, 2023
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it doesn't override
numericStorageIdin theMountPointbaseclassstorage_idwithmount_idinmountstable causing various issues with shares and mounts down the line #37473(see this one for a detailed explanation of the bug)
TODO
Checklist