Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation mail: Change subject if event got updated #36661

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

onny
Copy link

@onny onny commented Feb 10, 2023

Summary

Trying to implement the attendee invitation mail that the subject of the mail changes if an event is updated.

image

TODO

  • Add tests?

Checklist

@onny onny force-pushed the event-update-mail-subject branch 2 times, most recently from 5670862 to b24306a Compare February 10, 2023 14:13
@tcitworld
Copy link
Member

Looks good, thanks for the PR!

There's one failed test:

There was 1 failure:

1) OCA\DAV\Tests\unit\CalDAV\Schedule\IMipPluginTest::testParsingSingle
Expectation failed for method name is "addSubjectAndHeading" when invoked 1 time(s)
Parameter 4 for invocation OCA\DAV\CalDAV\Schedule\IMipService::addSubjectAndHeading(Mock_IEMailTemplate_2ba40391 Object (...), 'request', 'Mr. Wizard', 'Fellowship meeting without (!) Boromir', true): void does not match expected value.
Failed asserting that true matches expected false.

/drone/src/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php:247
/drone/src/apps/dav/tests/unit/CalDAV/Schedule/IMipPluginTest.php:231

Do you mind signing-off your commits?
https://github.com/nextcloud/server/pull/36661/checks?check_run_id=11254338082
https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

@szaimen szaimen added this to the Nextcloud 27 milestone Feb 11, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Feb 11, 2023
@szaimen szaimen modified the milestones: Nextcloud 27, Nextcloud 26 Feb 11, 2023
@miaulalala
Copy link
Contributor

You can run a single test locally by running:

NOCOVERAGE=1 ./autotest.sh sqlite path-to-your-file

in your root directory

@onny onny force-pushed the event-update-mail-subject branch 6 times, most recently from b4ac9d2 to 6e77eaa Compare February 19, 2023 19:13
@onny onny marked this pull request as ready for review February 19, 2023 19:14
@miaulalala
Copy link
Contributor

Drone tests fail with: "Waiting for Selenium". Can you rebase @onny ?

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 20, 2023
@onny onny force-pushed the event-update-mail-subject branch from 6e77eaa to 944efa3 Compare February 20, 2023 12:54
@onny onny requested review from miaulalala and removed request for ChristophWurst and miaulalala February 20, 2023 12:54
@onny onny requested review from tcitworld and miaulalala and removed request for tcitworld February 20, 2023 12:54
@ChristophWurst
Copy link
Member

Unsure if this should go into 26 or 27. It feels more like a feature/enhancement than a fix so I tend to say let's wait for the 26 branch-off.

@szaimen szaimen merged commit 0e5fcb4 into nextcloud:master Mar 16, 2023
@welcome
Copy link

welcome bot commented Mar 16, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the event invitation email subject to "Invitation updated: ..." in case an existing event gets updated
5 participants