-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitation mail: Change subject if event got updated #36661
Conversation
5670862
to
b24306a
Compare
Looks good, thanks for the PR! There's one failed test:
Do you mind signing-off your commits? |
You can run a single test locally by running: NOCOVERAGE=1 ./autotest.sh sqlite path-to-your-file in your root directory |
b4ac9d2
to
6e77eaa
Compare
Drone tests fail with: "Waiting for Selenium". Can you rebase @onny ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jonas Heinrich <[email protected]>
6e77eaa
to
944efa3
Compare
Unsure if this should go into 26 or 27. It feels more like a feature/enhancement than a fix so I tend to say let's wait for the 26 branch-off. |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
Trying to implement the attendee invitation mail that the subject of the mail changes if an event is updated.
TODO
Checklist