[master] fix(theming): fix admin images migration #36277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
skjnldsv
approved these changes
Jan 20, 2023
skjnldsv
changed the title
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
Pytal
approved these changes
Jan 20, 2023
szaimen
added
4. to release
|
Someone knows if CI failure is related? |
rakekniven
requested changes
Jan 21, 2023
| $images->delete(); | ||
| } catch (NotFoundException $e) { | ||
| } catch (Throwable $e) { | ||
| $output->warning($this->l10n->t('Failed to cleanup the old admin image folder', [$e->getMessage()])); |
There was a problem hiding this comment.
What about the other changes?
There was a problem hiding this comment.
What about the other changes?
Should be complete from my POV.
|
/rebase |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Reported at Transifex. Signed-off-by: rakekniven <[email protected]> Signed-off-by: rakekniven <[email protected]>
nextcloud-command
force-pushed
the
backport/36272/master
branch
from
26bd4e3 to
34824e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36272