Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NoteCard component in BackgroundJob settings #33942

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Use NoteCard component in BackgroundJob settings #33942

merged 1 commit into from
Sep 8, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 7, 2022 •
edited
Loading

Fix #33880

image

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Sep 7, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 7, 2022
@CarlSchwan CarlSchwan requested a review from a team September 7, 2022 12:04
@CarlSchwan CarlSchwan self-assigned this Sep 7, 2022
@CarlSchwan CarlSchwan requested review from PVince81, Pytal and szaimen and removed request for a team September 7, 2022 12:04
@CarlSchwan CarlSchwan force-pushed the background-job-notecart branch from a21dd8d to 04b2a3f Compare September 7, 2022 12:05
szaimen
szaimen approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

@blizzz blizzz mentioned this pull request Sep 7, 2022
Merged
@CarlSchwan CarlSchwan force-pushed the background-job-notecart branch from 04b2a3f to 0b77607 Compare September 8, 2022 12:13
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2022
@CarlSchwan CarlSchwan merged commit 9900a02 into master Sep 8, 2022
@CarlSchwan CarlSchwan deleted the background-job-notecart branch September 8, 2022 17:30
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish ui-refresh-feedback
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

[Bug]: NC 25 Color status button missing for Background jobs "Basic Settings tab"
3 participants
@CarlSchwan @Pytal @szaimen