[stable22] properly handle cases where cache wrappers block access #29509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
artonge,
CarlSchwan,
ChristophWurst and
icewind1991
CarlSchwan
approved these changes
Nov 1, 2021
skjnldsv
approved these changes
Nov 1, 2021
|
|
|
moved to 22.2.2 |
MichaIng
approved these changes
Nov 24, 2021
MichaIng
force-pushed
the
backport/28385/stable22
branch
from
d06bd1f to
e8d6ffd
Compare
|
I guess the Psalm error is because of the baseline change. In the diff this removal is not visible, which means that this still exists? EDIT: Yep that did it. Note that the baseline change was done in original PR against NC23 explicitly to solve a Psalm error. Obviously this does not apply for NC22: #28385 (comment) |
`CacheWrapper::formatCacheEntry` can return false for files that should be filtered out Signed-off-by: Robin Appelman <[email protected]>
MichaIng
force-pushed
the
backport/28385/stable22
branch
from
e8d6ffd to
c4fa59c
Compare
MichaIng
added
3. to review
|
Drone failures are unrelated. |
artonge
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #28385