Type the service registration #25359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
force-pushed
the
enhancement/typed-service-registration
branch
from
e933477 to
b40481a
Compare
ChristophWurst
requested review from
juliusknorr,
nickvergessen,
R0Wi,
rullzer and
kesselb
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/typed-service-registration
branch
from
b40481a to
aabd739
Compare
|
Psalm failure is unrelated and fixed with 130ce14 |
ChristophWurst
added
4. to release
rullzer
added a commit
that referenced
this pull request
Feb 10, 2021
As a wise man once said: "I like PRs that pass tests before merging" C. Wurst, Feb 9th 2021 Signed-off-by: Roeland Jago Douma <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we add more and more registrations to the bootstrap context, these stringly-typed array become a potential source for typos and error but also a maintenance burden. To fight this I think it's worth having a few dedicated types (classes) to abstract this.
My follow-up to this will be to also abstract the service locator pattern we currently have in the services that consume registered classes. That's some infrastructure code that we should abstract away as far as possible. It's also always pretty much the same coding pattern.
Todo:
Add some testsin Psalm we trust