Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalDAV calendar public sharing #1197

Merged
merged 44 commits into from
Sep 27, 2016
Merged

CalDAV calendar public sharing #1197

merged 44 commits into from
Sep 27, 2016

Conversation

LukasReschke
Copy link
Member

From owncloud/core#25351

Needs proper review and testing as there were some smaller conflicts. Will also myself go through it again as well.

@LukasReschke LukasReschke added 3. to review Waiting for reviews downstream labels Aug 30, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Aug 30, 2016
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @DeepDiver1975 and @tcitworld to be potential reviewers

@LukasReschke LukasReschke added 2. developing Work in progress 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 2. developing Work in progress labels Aug 30, 2016
LukasReschke
LukasReschke reviewed Aug 30, 2016
View reviewed changes
apps/dav/lib/CalDAV/CalDavBackend.php

/**
* CalDavBackend constructor.
*
* @param IDBConnection $db
* @param Principal $principalBackend
* @param IUserManager $userManager
* @param IConfig $config
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2016
@tcitworld
Copy link
Member

Please review again. :)

@tcitworld tcitworld mentioned this pull request Sep 19, 2016
Merged
@tcitworld tcitworld force-pushed the oc-public-sharing branch 3 times, most recently from 66d11ce to d0c5d5a Compare September 23, 2016 16:20
@MorrisJobke
Copy link
Member

@schiessle Signed-off is missing here - how to handle this case?

@LukasReschke
Copy link
Member Author

LukasReschke commented Sep 26, 2016 •
edited
Loading

@schiessle Signed-off is missing here - how to handle this case?

Ignore. I won't touch every old PR and add a "Signed-off" at every commit (aka huge waste of time 🙈). Otherwise, @schiessle can happily volunteer for doing so and train his 10 finger typing system 🚀

@tcitworld
Copy link
Member

I can squash mine for what it's worth, but I guess you don't want all of them squashed.

@LukasReschke
Copy link
Member Author

Let's get this in 👍

@LukasReschke LukasReschke merged commit 06e969c into master Sep 27, 2016
@LukasReschke LukasReschke deleted the oc-public-sharing branch September 27, 2016 16:51
@georgehrke
Copy link
Member

Thanks everyone who helped and thanks a lot to @tcitworld :)

@rullzer rullzer mentioned this pull request Nov 4, 2016
Closed
@vasyugan
Copy link

Is this in NC 11?

@nickvergessen
Copy link
Member

yes

@georgehrke
Copy link
Member

Yes, it is

@tcitworld
Copy link
Member

You guys are too fast for me.

@LukasReschke
Copy link
Member Author

Yes

@blizzz
Copy link
Member

blizzz commented Dec 21, 2016

да

@jospoortvliet
Copy link
Member

No!

Wait, what?

👍

@tcitworld tcitworld mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.
10 participants
@LukasReschke @mention-bot @tcitworld @MorrisJobke @georgehrke @vasyugan @nickvergessen @blizzz @jospoortvliet @DeepDiver1975