Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Shift clicking to select a range of files no longer works #48886

Closed
5 of 8 tasks
gerowin opened this issue Oct 25, 2024 · 3 comments · Fixed by #49134
Closed
5 of 8 tasks

[Bug]: Shift clicking to select a range of files no longer works #48886

gerowin opened this issue Oct 25, 2024 · 3 comments · Fixed by #49134
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews 30-feedback bug feature: files
Milestone
Nextcloud 30.0.3

Comments

@gerowin
Copy link

gerowin commented Oct 25, 2024 •
edited by joshtrichards
Loading

⚠️ This issue respects the following points: ⚠️

Bug description

Since updating to 30.0.1, shift clicking a range of files in the web interface no longer functions properly. It worked fine before the update. This is a feature I use quite regularly when I take a trip and want to bulk move photos I've taken from "InstantUpload" to a more permanent storage location.

Steps to reproduce

  1. Open any folder with multiple files in it.
  2. Check the box next to any file to select it.
  3. While holding shift, click the checkbox next to any other file. Normally this would select that file, and all files between that file and the one selected in step 1. It does not.

Expected behavior

I expect that, when I shift click an additional file in the web interface, it selects that second file and every un-selected file between it and the first file I selected.

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "10.1.1.2",
            "marcusandash.net",
            "apocrypha",
            "adams-server"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "30.0.1.2",
        "overwrite.cli.url": "https:\/\/marcusandash.net",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "app_install_overwrite": [
            "spgverein",
            "dicomviewer",
            "files_external_onedrive",
            "keeweb",
            "tasks",
            "duplicatefinder",
            "audioplayer",
            "socialsharing_facebook",
            "onlyoffice",
            "talk_matterbridge",
            "twofactor_totp",
            "qownnotesapi",
            "documentserver_community",
            "metadata",
            "bruteforcesettings",
            "files_antivirus",
            "music",
            "phonetrack",
            "news",
            "socialsharing_email",
            "richdocumentscode",
            "socialsharing_twitter",
            "files_retention",
            "files_rightclick",
            "facerecognition",
            "files_3dmodelviewer",
            "camerarawpreviews",
            "deck",
            "forms"
        ],
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "maintenance": false,
        "maintenance_window_start": 1,
        "theme": "",
        "loglevel": 0,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "filelocking.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "updater.release.channel": "stable",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [],
        "twofactor_enforced_excluded_groups": [],
        "mail_smtpauthtype": "LOGIN",
        "trashbin_retention_obligation": "30, 60",
        "versions_retention_obligation": "30, 180",
        "default_phone_region": "US",
        "enforce_theme": ""
    }
}

List of activated Apps

  - activity: 3.0.0
  - admin_audit: 1.20.0
  - app_api: 4.0.0
  - audioplayer: 3.4.1
  - bookmarks: 15.0.2
  - bruteforcesettings: 3.0.0
  - calendar: 5.0.1
  - camerarawpreviews: 0.8.5
  - circles: 30.0.0-dev
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.0
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - deck: 1.14.1
  - dicomviewer: 2.2.1
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_accesscontrol: 1.20.1
  - files_antivirus: 5.6.0
  - files_automatedtagging: 1.20.0
  - files_downloadlimit: 3.0.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_retention: 1.19.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - firstrunwizard: 3.0.0
  - forms: 4.3.2
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - music: 2.0.1
  - nextcloud_announcements: 2.0.0
  - notes: 4.11.0
  - notifications: 3.0.0
  - oauth2: 1.18.1
  - password_policy: 2.0.0
  - phonetrack: 0.8.1
  - photos: 3.0.2
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - qownnotesapi: 24.9.0
  - recommendations: 3.0.0
  - related_resources: 1.5.0
  - richdocuments: 8.5.2
  - richdocumentscode: 24.4.802
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - socialsharing_email: 3.2.0
  - spreed: 20.0.1
  - support: 2.0.0
  - survey_client: 2.0.0
  - suspicious_login: 8.0.0
  - systemtags: 1.20.0
  - tasks: 0.16.1
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - twofactor_totp: 12.0.0-dev
  - updatenotification: 1.20.0
  - user_status: 1.10.0
  - viewer: 3.0.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - encryption: 2.18.0
  - files_external: 1.22.0 (installed 1.15.0)
  - twofactor_nextcloud_notification: 4.0.0
  - user_ldap: 1.21.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

"->"},{"file":"/var/www/nextcloud/cron.php","line":148,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->"}],"File":"/var/www/nextcloud/lib/private/DB/Connection.php","Line":402,"message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","tables":["oc_appconfig","oc_jobs","oc_user_status","oc_notifications_settings","oc_music_albums","oc_filecache","oc_music_artists","oc_music_tracks","oc_music_bookmarks","oc_music_podcast_episodes","oc_music_podcast_channels","oc_talk_bridges","oc_files_antivirus","oc_mounts","oc_deck_sessions"],"reads":["oc_jobs"],"exception":{},"CustomMessage":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"CLI cron call has selected job OCA\\DAV\\BackgroundJob\\UploadCleanup (id: 821877, arguments: {\"uid\":\"gerowen\",\"folder\":\"735bbc201450734b93706d899c7d398d\"})","userAgent":"--","version":"30.0.1.2","data":{"app":"cron"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","userAgent":"--","version":"30.0.1.2","exception":{"Exception":"Exception","Message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/DB/ConnectionAdapter.php","line":50,"function":"executeQuery","class":"OC\\DB\\Connection","type":"->"},{"file":"/var/www/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":289,"function":"executeQuery","class":"OC\\DB\\ConnectionAdapter","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/JobList.php","line":192,"function":"executeQuery","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":148,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->"}],"File":"/var/www/nextcloud/lib/private/DB/Connection.php","Line":402,"message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","tables":["oc_appconfig","oc_jobs","oc_user_status","oc_notifications_settings","oc_music_albums","oc_filecache","oc_music_artists","oc_music_tracks","oc_music_bookmarks","oc_music_podcast_episodes","oc_music_podcast_channels","oc_talk_bridges","oc_files_antivirus","oc_mounts","oc_deck_sessions"],"reads":["oc_jobs"],"exception":{},"CustomMessage":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"CLI cron call has selected job OCA\\DAV\\BackgroundJob\\UploadCleanup (id: 821879, arguments: {\"uid\":\"gerowen\",\"folder\":\"ca9963b2f1876c77615ea013280c3122\"})","userAgent":"--","version":"30.0.1.2","data":{"app":"cron"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","userAgent":"--","version":"30.0.1.2","exception":{"Exception":"Exception","Message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/DB/ConnectionAdapter.php","line":50,"function":"executeQuery","class":"OC\\DB\\Connection","type":"->"},{"file":"/var/www/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":289,"function":"executeQuery","class":"OC\\DB\\ConnectionAdapter","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/JobList.php","line":192,"function":"executeQuery","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":148,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->"}],"File":"/var/www/nextcloud/lib/private/DB/Connection.php","Line":402,"message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","tables":["oc_appconfig","oc_jobs","oc_user_status","oc_notifications_settings","oc_music_albums","oc_filecache","oc_music_artists","oc_music_tracks","oc_music_bookmarks","oc_music_podcast_episodes","oc_music_podcast_channels","oc_talk_bridges","oc_files_antivirus","oc_mounts","oc_deck_sessions"],"reads":["oc_jobs"],"exception":{},"CustomMessage":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"CLI cron call has selected job OCA\\DAV\\BackgroundJob\\UploadCleanup (id: 821881, arguments: {\"uid\":\"gerowen\",\"folder\":\"b48b05377bb38add56e8bd167a545485\"})","userAgent":"--","version":"30.0.1.2","data":{"app":"cron"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","userAgent":"--","version":"30.0.1.2","exception":{"Exception":"Exception","Message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/DB/ConnectionAdapter.php","line":50,"function":"executeQuery","class":"OC\\DB\\Connection","type":"->"},{"file":"/var/www/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":289,"function":"executeQuery","class":"OC\\DB\\ConnectionAdapter","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/JobList.php","line":192,"function":"executeQuery","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":148,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->"}],"File":"/var/www/nextcloud/lib/private/DB/Connection.php","Line":402,"message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","tables":["oc_appconfig","oc_jobs","oc_user_status","oc_notifications_settings","oc_music_albums","oc_filecache","oc_music_artists","oc_music_tracks","oc_music_bookmarks","oc_music_podcast_episodes","oc_music_podcast_channels","oc_talk_bridges","oc_files_antivirus","oc_mounts","oc_deck_sessions"],"reads":["oc_jobs"],"exception":{},"CustomMessage":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"--","message":"CLI cron call has selected job OCA\\DAV\\BackgroundJob\\UploadCleanup (id: 822008, arguments: {\"uid\":\"hermione\",\"folder\":\"e573b2b868f6b187ed362d48125cd15b\"})","userAgent":"--","version":"30.0.1.2","data":{"app":"cron"}}
{"reqId":"E9Y9rhTzwVKdH7F4WFcu","level":0,"time":"2024-10-25T02:25:30+00:00","remoteAddr":"","user":"--","app":"no app in context","method":"","url":"--","message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","userAgent":"--","version":"30.0.1.2","exception":{"Exception":"Exception","Message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/DB/ConnectionAdapter.php","line":50,"function":"executeQuery","class":"OC\\DB\\Connection","type":"->"},{"file":"/var/www/nextcloud/lib/private/DB/QueryBuilder/QueryBuilder.php","line":289,"function":"executeQuery","class":"OC\\DB\\ConnectionAdapter","type":"->"},{"file":"/var/www/nextcloud/lib/private/BackgroundJob/JobList.php","line":192,"function":"executeQuery","class":"OC\\DB\\QueryBuilder\\QueryBuilder","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":148,"function":"getNext","class":"OC\\BackgroundJob\\JobList","type":"->"}],"File":"/var/www/nextcloud/lib/private/DB/Connection.php","Line":402,"message":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1","tables":["oc_appconfig","oc_jobs","oc_user_status","oc_notifications_settings","oc_music_albums","oc_filecache","oc_music_artists","oc_music_tracks","oc_music_bookmarks","oc_music_podcast_episodes","oc_music_podcast_channels","oc_talk_bridges","oc_files_antivirus","oc_mounts","oc_deck_sessions"],"reads":["oc_jobs"],"exception":{},"CustomMessage":"dirty table reads: SELECT * FROM `*PREFIX*jobs` WHERE (`reserved_at` <= :dcValue1) AND (`last_checked` <= :dcValue2) ORDER BY `last_checked` ASC LIMIT 1"}}

Additional info

I've tried to perform the action using both Firefox and Chromium based browsers.
@gerowin gerowin added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 25, 2024
@gerowin
Copy link
Author

gerowin commented Oct 25, 2024 •
edited
Loading

The log file contents posted here is not complete because the full original file is 17MB in size. I should probably rotate the log file manually. Entering too many characters in the input field caused the issue to not submit to github so I truncated it down with tail until it took; 10,000 characters seemed to work. That's why the beginning of the file appears to be in the middle of an entry.

@khlschrnk khlschrnk mentioned this issue Nov 2, 2024
Closed
8 tasks
@wkobiela
Copy link

wkobiela commented Nov 6, 2024

Bumping. This is really annoying, that bulk-select is not working anymore.

@skjnldsv skjnldsv mentioned this issue Nov 7, 2024
Merged
@skjnldsv skjnldsv self-assigned this Nov 7, 2024
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 7, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 7, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

30 fix #49136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews 30-feedback bug feature: files
Projects
None yet
Milestone
Nextcloud 30.0.3
Development

Successfully merging a pull request may close this issue.

fix(files): multiselect and filters store declaration nextcloud/server
4 participants
@wkobiela @solracsf @skjnldsv @gerowin