Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Files App: Shift + Select to select ranges not working with Firefox #42202

Closed
5 of 8 tasks
thgoebel opened this issue Dec 13, 2023 · 11 comments · Fixed by nextcloud-libraries/nextcloud-vue#4999
Closed
5 of 8 tasks
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug regression

Comments

@thgoebel
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

According to the announcement blog post for Nextcloud 28, the files app now has "Better selection handling (shift + select to select range)".

However, this is not working for me.

Steps to reproduce

  1. Open the Files app
  2. Click on a file's empty check box to select the first file (NOT holding Shift)
  3. Click on another file's empty check box to while holding Shift

Expected behavior

The file range should be selected.

Actual behaviour

When clicking on the second file when holding Shift, nothing happens. The second file is not even individually selected.

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "timeout": 0,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "filelocking.enabled": true,
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.example.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/cloud.example.com",
        "dbtype": "mysql",
        "version": "28.0.0.11",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "overwritehost": "cloud.example.com",
        "overwriteprotocol": "https",
        "overwritewebroot": "\/",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 0,
        "maintenance": false,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "PLAIN",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "tls",
        "forcessl": true,
        "default_phone_region": "DE",
        "theme": "",
        "app_install_overwrite": [
            "whiteboard",
            "twofactor_nextcloud_notification",
            "suspicious_login",
            "qownnotesapi",
            "quota_warning",
            "twofactor_admin",
            "groupfolders"
        ],
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\BMP",
            "OC\\Preview\\GIF",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\Krita",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\MP3",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\PNG",
            "OC\\Preview\\TXT",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie"
        ]
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - admin_audit: 1.18.0
  - bruteforcesettings: 2.8.0
  - cloud_federation_api: 1.11.0
  - comments: 1.18.0
  - contactsinteraction: 1.9.0
  - cospend: 1.5.12
  - dav: 1.29.1
  - deck: 1.12.0
  - federatedfilesharing: 1.18.0
  - federation: 1.18.0
  - files: 2.0.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - firstrunwizard: 2.17.0
  - forms: 4.0.0
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - nextcloud_announcements: 1.17.0
  - notes: 4.9.0
  - notifications: 2.16.0
  - notify_push: 0.6.5
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - photos: 2.4.0
  - polls: 6.0.1
  - previewgenerator: 5.4.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - qownnotesapi: 23.12.0
  - quota_warning: 1.18.0
  - recognize: 6.0.1
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - richdocuments: 8.3.0
  - richdocumentscode: 23.5.602
  - serverinfo: 1.18.0
  - settings: 1.10.0
  - sharebymail: 1.18.0
  - support: 1.11.0
  - survey_client: 1.16.0
  - suspicious_login: 6.0.0
  - systemtags: 1.18.0
  - text: 3.9.1
  - theming: 2.3.0
  - translate: 2.0.0
  - twofactor_admin: 4.4.0
  - twofactor_backupcodes: 1.17.0
  - twofactor_nextcloud_notification: 3.8.0
  - twofactor_totp: 10.0.0-beta.2
  - twofactor_webauthn: 1.3.2
  - updatenotification: 1.18.0
  - user_status: 1.8.1
  - viewer: 2.2.0
  - weather_status: 1.8.0
  - workflowengine: 2.10.0
Disabled:
  - circles: 28.0.0-dev (installed 28.0.0-dev)
  - dashboard: 7.8.0 (installed 7.0.0)
  - encryption: 2.16.0
  - files_external: 1.20.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - groupfolders: 16.0.0 (installed 16.0.0)
  - integration_deepl: 1.1.1 (installed 1.1.1)
  - user_ldap: 1.19.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Nothing interesting in there.

Additional info

Metadata

  • Firefox 120.0.1
  • Ubuntu 23.10
@thgoebel thgoebel added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 13, 2023
@hede5562
Copy link

Not only this functionality is gone but also other ways like: #17313 (comment)
I do not find any way to select a file rang in a folder with many files except for individually selecting every single file or all files at once.

@skjnldsv
Copy link
Member

Hmmm, this was working during 28 development, let me have a look

@skjnldsv skjnldsv self-assigned this Dec 27, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Dec 27, 2023

Ah, broken on firefox. Chrome works! Fix incoming

https://bugzilla.mozilla.org/show_bug.cgi?id=559506: 14 years ago
Amazing!

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of regression and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 27, 2023
@skjnldsv skjnldsv changed the title [Bug]: Files App: Shift + Select to select ranges not working [Bug]: Files App: Shift + Select to select ranges not working with Firefox Dec 27, 2023
@hede5562
Copy link

Oh, yes @skjnldsv, you're right, it seems to be specific for Firefox. So my current workaround is to use Chromium.

Will there be a fix for Firefox? As clicking the name instead of the checkbox worked before with old Nextcloud versions. Nevertheless Mozilla should fix Firefox' behavior also. But if something didn't get fixed within 14 years I don't think they will do so in the near future. ;-)

Btw. do you really think the Mozilla bug is applicable here? The bug is for "shift+click on a label for a checkbox" while here with Nextcloud it's shift-clicking the checkbox itself what's not working in Firefox (but works in chrome as expected).

@skjnldsv
Copy link
Member

Btw. do you really think the Mozilla bug is applicable here? The bug is for "shift+click on a label for a checkbox" while here with Nextcloud it's shift-clicking the checkbox itself what's not working in Firefox (but works in chrome as expected).

Yeah, this is precisely the issue.
We use a custom checkbox which we spend a lot of time making aria compliant (accessibility)
And that involve using a nested label and input checkbox.

Unfortunately the bug is here since 14 years in Firefox and, having spent a bit of time digging around, we're not the only one being annoyed by this.

We'll try to find a workaround for Firefox as this mus be resolved without breaking accessibility handling.

@tincanfury
Copy link

Is there a way to get range selection from a mobile or tablet browser without a physical keyboard?

@damnshaneisthatu
Copy link

Is this still working on Chrome? Because I cannot get it to work on any browsers now.

@khlschrnk
Copy link

Same here, since nextcloud 30 I am also not able to select multiple files anymore, independent from the browser. Can this issue be reopened?

@hede5562
Copy link

hede5562 commented Oct 21, 2024

Same here.
Even if it feels like a regression, it's probably a new Bug.
(I think it's a different problem because this time it's not only hitting firefox but also chromium)

@skjnldsv
Copy link
Member

Please someone open a new issue and fill the template

@khlschrnk
Copy link

FYI: a new issue was opened last week: #48886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants