Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth 2.0 Client list breaks when secret is shown #12302

Closed
MariusBluem opened this issue Nov 6, 2018 · 5 comments · Fixed by #22502
Closed

OAuth 2.0 Client list breaks when secret is shown #12302

MariusBluem opened this issue Nov 6, 2018 · 5 comments · Fixed by #22502
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. help wanted papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 20

Comments

@MariusBluem
Copy link
Member

nov-06-2018 09-20-11

We could fix this by not showing the secret and instead only provide a "copy secret to clipboard" link.

Version: Master
Browser: Firefox

@nextcloud/designers
@MariusBluem MariusBluem added design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Nov 6, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #11056 (OAuth 2.0: ClientNotFoundException), #3599 (Nextcloud as OAuth 2.0 provider), #10442 (Contact list broken layout), #11751 (14.0.2), and #2595 (Client fails to connect since 10.0.2).

@jancborchardt jancborchardt added this to the Nextcloud 16 milestone Nov 7, 2018
@jancborchardt
Copy link
Member

jancborchardt commented Nov 7, 2018 •
edited
Loading

This already is too wide even just with the Client ID and the rest. And it looks like a very bland table.
We should check how others do it – here are examples from Twitter and Github (or is this not a comparable view?):

  • with icons
  • prominent name
  • when it was last used

github oauth
twitter oauth

@rullzer rullzer modified the milestones: Nextcloud 16, Nextcloud 17 Feb 26, 2019
@rullzer
Copy link
Member

rullzer commented Feb 26, 2019

Well our OAuth is the other way around. We are the server.
Also we can't show the icons since well we do not know.

Of course we could somehow improve here sure. But not for 16 I guess anymore.

@tcitworld

This comment has been minimized.

Sign in to view
@rullzer

This comment has been minimized.

Sign in to view
@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@MorrisJobke MorrisJobke added papercut Annoying recurring issue with possibly simple fix. and removed enhancement labels Aug 20, 2020
rullzer added a commit that referenced this issue Aug 30, 2020
@rullzer
Pimp Oauth2 table
5450d7f 
Fixes #12302

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer mentioned this issue Aug 30, 2020
Merged
juliusknorr pushed a commit that referenced this issue Aug 31, 2020
@rullzer @juliusknorr
Pimp Oauth2 table
1b56ae5 
Fixes #12302

Signed-off-by: Roeland Jago Douma <[email protected]>
juliusknorr pushed a commit that referenced this issue Aug 31, 2020
@rullzer @juliusknorr
Pimp Oauth2 table
5659e69 
Fixes #12302

Signed-off-by: Roeland Jago Douma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. help wanted papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging a pull request may close this issue.

Pimp Oauth2 table nextcloud/server
6 participants
@rullzer @MorrisJobke @jancborchardt @tcitworld @MariusBluem @nextcloud-bot