Merge pull request #49239 from nextcloud/backport/49226/stable30

nextcloud · Nov 13, 2024 · cda0a65 · cda0a65
2 parents 339f6ff + bf728f9
commit cda0a65
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/apps/dav/lib/Files/Sharing/FilesDropPlugin.php b/apps/dav/lib/Files/Sharing/FilesDropPlugin.php
@@ -64,7 +64,7 @@ public function beforeMethod(RequestInterface $request, ResponseInterface $respo
 		// Extract the attributes for the file request
 		$isFileRequest = false;
 		$attributes = $this->share->getAttributes();
-		$nickName = $request->getHeader('X-NC-Nickname');
+		$nickName = $request->hasHeader('X-NC-Nickname') ? urldecode($request->getHeader('X-NC-Nickname')) : null;
 		if ($attributes !== null) {
 			$isFileRequest = $attributes->getAttribute('fileRequest', 'enabled') === true;
 		}

diff --git a/apps/files_sharing/js/files_drop.js b/apps/files_sharing/js/files_drop.js
@@ -48,7 +48,7 @@
 			}
 
 			if (localStorage.getItem('nick') !== null) {
-				data.headers['X-NC-Nickname'] = localStorage.getItem('nick')
+				data.headers['X-NC-Nickname'] = encodeURIComponent(localStorage.getItem('nick'))
 			}
 
 			$('#drop-upload-done-indicator').addClass('hidden');

diff --git a/build/integration/features/bootstrap/FilesDropContext.php b/build/integration/features/bootstrap/FilesDropContext.php
@@ -32,7 +32,7 @@ public function droppingFileWith($path, $content, $nickName = null) {
 		];
 
 		if ($nickName) {
-			$options['headers']['X-NC-NICKNAME'] = $nickName;
+			$options['headers']['X-NC-NICKNAME'] = urlencode($nickName);
 		}
 
 		$options['body'] = \GuzzleHttp\Psr7\Utils::streamFor($content);