Convert email and contact shares to external shares on first usage #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dartcafe <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: dartcafe <[email protected]>
|
/backport to next |
Signed-off-by: dartcafe <[email protected]>
|
damn. Did not wanted to merge it now. sry |
dartcafe
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: dartcafe <[email protected]>
Merged
backportbot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: dartcafe <[email protected]>
dartcafe
added a commit
that referenced
this pull request
Sep 24, 2024
[next] fix aftermath of #3716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of this fix, which should be appied to #3714 first.
The cause of this behavior is #3125. This change removed the initial registration dialog after entering a poll via share token. The dialog was meant to allow participants
The second use case was eliminated with the issue causing PR. The result was, that the share type stays the initial type.
This PR now converts theese shares into external sharesm by changing the type and replacing the userId by a generated one, to make sure, sensitive informations get removed (like mail address in email shares).