Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space in token causes 404 on logout #3677

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: space in token causes 404 on logout #3677

merged 1 commit into from
Aug 29, 2024

Conversation

hamza221
Copy link
Contributor

I noticed after loging out from a public share sometime a space character gets added to the token -> route which causes a 404
I'm still not sure why it happens and it doesn't look deterministic, I'm still investigating
image
Notice the extra space in the following screenshots
image
image

Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. Never saw that. How can a space get added to the cookie name, which is returned from the delete function.

I think it better gets trimmed inside the function.

https://github.com/nextcloud/polls/blob/7e41c266f9e2820163afa20859e876f33650f3e9/src/js/helpers/modules/cookieHelper.js#L54C1-L61C2

@hamza221
Copy link
Contributor Author

Strange. Never saw that. How can a space get added to the cookie name, which is returned from the delete function.

I think it better gets trimmed inside the function.

https://github.com/nextcloud/polls/blob/7e41c266f9e2820163afa20859e876f33650f3e9/src/js/helpers/modules/cookieHelper.js#L54C1-L61C2

I also couldn't figure out why it's happening

@dartcafe
Copy link
Collaborator

🤷

@hamza221 hamza221 merged commit 70629df into master Aug 29, 2024
21 checks passed
@AndyScherzinger AndyScherzinger added this to the 7.2.1 milestone Aug 29, 2024
dartcafe added a commit that referenced this pull request Sep 2, 2024
Signed-off-by: dartcafe <[email protected]>
dartcafe added a commit that referenced this pull request Sep 2, 2024
@dartcafe dartcafe modified the milestones: 7.2.1, 7.2.2 Sep 5, 2024
@dartcafe dartcafe deleted the fix/wrong-route branch October 2, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants