Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-6] intoduce internal UserSession #3503

Closed
wants to merge 6 commits into from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 14, 2024

Cherry-pick from master with conflicts

Backport of #3498

Cherry-pick from master with conflicts

Signed-off-by: dartcafe <[email protected]>
@come-nc come-nc self-assigned this May 14, 2024
Removes unused import, and fix syntax error in PublicController

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc changed the title intoduce internal UserSession [stable-6] intoduce internal UserSession May 14, 2024
@come-nc come-nc added this to the 6.4 milestone May 14, 2024
@delete-merged-branch delete-merged-branch bot deleted the branch stable-6 May 14, 2024 12:53
@come-nc come-nc changed the base branch from backport/3477/stable-6 to stable-6 May 14, 2024 12:55
@come-nc come-nc marked this pull request as ready for review May 14, 2024 12:55
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc requested a review from dartcafe May 14, 2024 13:56
@come-nc
Copy link
Contributor Author

come-nc commented May 14, 2024

⚠️ This breaks sharing poll

@come-nc
Copy link
Contributor Author

come-nc commented May 14, 2024

⚠️ This breaks sharing poll

Some part of #3381 is missing, so that Acl does not rely on getShare to see userRole.

@dartcafe
Copy link
Collaborator

Did not expect you trying to backport this.

@come-nc come-nc marked this pull request as draft May 21, 2024 07:04
@come-nc come-nc mentioned this pull request May 21, 2024
3 tasks
@come-nc come-nc closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants