Skip to content

enh: Migrate from custom webdav v4 handling to webdav v5 with @nextcloud/files #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 9, 2025
Merged

enh: Migrate from custom webdav v4 handling to webdav v5 with @nextcloud/files #2312

merged 8 commits into from
Apr 9, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 4, 2024

Lets use webdav v5 and helpers from @nextcloud/files instead of old webdav v4 with custom patching.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Feb 4, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 4, 2024
@susnux susnux requested a review from artonge February 4, 2024 00:14
@susnux susnux force-pushed the enh/migrate-to-webdav-v5 branch from 8731f8a to d2509b7 Compare February 4, 2024 00:29
artonge
artonge reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 😍
I left a few questions/comments

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

This was referenced Mar 12, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@susnux susnux force-pushed the enh/migrate-to-webdav-v5 branch 2 times, most recently from 0bacc16 to b33af7d Compare March 23, 2024 17:23
@susnux susnux requested a review from artonge March 23, 2024 17:24
@susnux
Copy link
Contributor Author

susnux commented Mar 23, 2024

@artonge I resolved the conflicts and merged in your suggestions, seems to work fine (did some testing).

artonge
artonge reviewed Mar 25, 2024
View reviewed changes
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@blizzz blizzz mentioned this pull request Apr 4, 2024
Merged
67 tasks
@susnux susnux modified the milestones: Nextcloud 29, Nextcloud 30 Apr 4, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@susnux susnux mentioned this pull request Aug 8, 2024
Closed
4 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 22, 2024
Merged
44 tasks
@blizzz blizzz mentioned this pull request Aug 29, 2024
Merged
24 tasks
@artonge artonge force-pushed the enh/migrate-to-webdav-v5 branch 6 times, most recently from a3f7bca to fa57751 Compare April 9, 2025 13:50
susnux and others added 7 commits April 9, 2025 15:55
@susnux @artonge
fix: Update packages and remove unneeded patching
2cc7d85 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @artonge
enh: Migrate to use webdav v5 and @nextcloud/files for DAV handling
4a65c8c 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @artonge
fix(PhotosPicker): Adjust picker to only show sidebar if needed
a5afec6 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @artonge
fix: Replace console with our logger that also handles log levels
bb2e953 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux @artonge
fix: Initialize the photosLocationFolder on first load
2ae90e0 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@artonge
fix: Correctly handle abort error
e547054 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
test: Wait for location to be saved
1a69421 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the enh/migrate-to-webdav-v5 branch from fa57751 to 1a69421 Compare April 9, 2025 13:56
@artonge
Copy link
Collaborator

artonge commented Apr 9, 2025

/compile /

@nextcloud-command
chore(assets): Recompile assets
3edaf55 
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge merged commit 45b9970 into master Apr 9, 2025
43 checks passed
@artonge artonge deleted the enh/migrate-to-webdav-v5 branch April 9, 2025 14:06
@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Apr 9, 2025
@backportbot backportbot bot mentioned this pull request Apr 9, 2025
Merged
@artonge
Copy link
Collaborator

artonge commented Apr 9, 2025

/backport e547054 1a69421 to stable30

@artonge
Copy link
Collaborator

artonge commented Apr 9, 2025

/backport e547054 1a69421 to stable29

@backportbot backportbot bot added backport-request Pending backport by the backport-bot and removed backport-request Pending backport by the backport-bot labels Apr 9, 2025
This was referenced Apr 9, 2025
Merged
Closed
@backportbot backportbot bot added backport-request Pending backport by the backport-bot and removed backport-request Pending backport by the backport-bot labels Apr 9, 2025
@nextcloud nextcloud deleted a comment from backportbot bot Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request feedback-requested
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @artonge @blizzz @nextcloud-command